Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce peak memory consumption during Datumaro and COCO extractors #1061

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Reduce peak memory consumption during Datumaro and COCO extractors #1061

merged 8 commits into from
Jul 6, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jun 27, 2023 •
edited
Loading

Summary

For importing COCO data,
As-is:
image

To-be:
image

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners June 27, 2023 06:47
@wonjuleee wonjuleee force-pushed the mem_profile branch 3 times, most recently from 6104a12 to 4e08d46 Compare June 30, 2023 06:49
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jul 4, 2023
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 4, 2023
vinnamkim
vinnamkim approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee requested a review from sooahleex July 6, 2023 01:05
sooahleex
sooahleex approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim merged commit f00acf8 into openvinotoolkit:develop Jul 6, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim approved these changes

@sooahleex sooahleex sooahleex approved these changes

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@jihyeonyi jihyeonyi Awaiting requested review from jihyeonyi jihyeonyi is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wonjuleee @vinnamkim @sooahleex