Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more ModelInterpreter for OTX detection models #1064

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Add more ModelInterpreter for OTX detection models #1064

merged 3 commits into from
Jul 4, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jun 27, 2023 •
edited
Loading

Summary

  • Add built-in model interpreter for the rest of the OTX detection models: SSD and YOLOX

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Add more ModelInterpreter for OTX detection models
3d2e50b 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Jun 27, 2023
@vinnamkim vinnamkim marked this pull request as ready for review June 27, 2023 09:22
@vinnamkim vinnamkim requested review from a team as code owners June 27, 2023 09:22
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jun 27, 2023
@vinnamkim
Update CHANGELOG.md
640190c 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
sooahleex
sooahleex approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim merged commit c5e8a28 into openvinotoolkit:develop Jul 4, 2023
4 checks passed
@vinnamkim vinnamkim deleted the feature/add-more-interp-for-otx-det-model branch July 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonjuleee wonjuleee wonjuleee approved these changes

@sooahleex sooahleex sooahleex approved these changes

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily chuneuny-emily is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
FEATURE New feature & functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnamkim @wonjuleee @sooahleex