Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation and notebook example for Prune API #1070

Merged
merged 14 commits into from
Jul 11, 2023
Merged

Add documentation and notebook example for Prune API #1070

merged 14 commits into from
Jul 11, 2023

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Jun 29, 2023 •
edited
Loading

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex added this to the 1.4.0 milestone Jun 29, 2023
@sooahleex sooahleex added the DOC Improvements or additions to documentation label Jun 29, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@sooahleex sooahleex changed the title Add documentation and Jupyter notebook for Prune API Add documentation and notebook example for Prune API Jul 10, 2023
@sooahleex sooahleex changed the base branch from develop to releases/1.4.0 July 10, 2023 02:41
@sooahleex sooahleex marked this pull request as ready for review July 10, 2023 03:05
@sooahleex sooahleex requested review from a team as code owners July 10, 2023 03:05
@review-notebook-app
Copy link

review-notebook-app bot commented Jul 10, 2023 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

wonjuleee commented on 2023-07-10T06:16:04Z
----------------------------------------------------------------

In overall, we may need to introduce some insights over label distributions, e.g., random almost kept the original distribution, while query_clust distorted much that.

By the way, there is any plot for pruning with label information, which is expected to show the balanced sampling.

@review-notebook-app
Copy link

review-notebook-app bot commented Jul 10, 2023 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

wonjuleee commented on 2023-07-10T06:16:05Z
----------------------------------------------------------------

Where can I obtain 2.19% improvement? compare to the full dataset?

@review-notebook-app
Copy link

review-notebook-app bot commented Jul 10, 2023 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

wonjuleee commented on 2023-07-10T06:16:06Z
----------------------------------------------------------------

here also. it looks like weird to me.

vinnamkim
vinnamkim reviewed Jul 10, 2023
View reviewed changes
src/datumaro/components/algorithms/hash_key_inference/prune.py Outdated Show resolved Hide resolved
src/datumaro/components/algorithms/hash_key_inference/prune.py Outdated Show resolved Hide resolved
docs/source/docs/command-reference/context_free/prune.md Outdated Show resolved Hide resolved
docs/source/docs/command-reference/context_free/prune.md Outdated Show resolved Hide resolved
docs/source/docs/command-reference/context_free/prune.md Outdated Show resolved Hide resolved
docs/source/docs/level-up/intermediate_skills/12_data_pruning.rst Outdated Show resolved Hide resolved
docs/source/docs/level-up/intermediate_skills/12_data_pruning.rst Outdated Show resolved Hide resolved
docs/source/docs/level-up/intermediate_skills/index.rst Outdated Show resolved Hide resolved
vinnamkim
vinnamkim approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @wonjuleee's comments on the notebook example should be resolved.

wonjuleee
wonjuleee approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@sooahleex sooahleex merged commit 3bbb425 into openvinotoolkit:releases/1.4.0 Jul 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim approved these changes

@wonjuleee wonjuleee wonjuleee approved these changes

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@MarkByun MarkByun Awaiting requested review from MarkByun MarkByun is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
DOC Improvements or additions to documentation
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sooahleex @vinnamkim @wonjuleee