Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new CLI command: datum format #1570

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jul 22, 2024

Summary

How to test

Added unit tests as well.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim requested review from a team as code owners July 22, 2024 09:49
@vinnamkim vinnamkim requested review from itrushkin and removed request for a team July 22, 2024 09:49
@vinnamkim vinnamkim changed the title Enhance cli format helper Add a new CLI command: datum format Jul 22, 2024
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (9bdf8de) to head (5438516).
Report is 6 commits behind head on develop.

Files Patch % Lines
src/datumaro/cli/__main__.py 0.00% 11 Missing ⚠️
src/datumaro/cli/helpers/format.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1570      +/-   ##
===========================================
- Coverage    81.03%   81.03%   -0.01%     
===========================================
  Files          276      278       +2     
  Lines        32430    32468      +38     
  Branches      6595     6599       +4     
===========================================
+ Hits         26280    26309      +29     
- Misses        4696     4705       +9     
  Partials      1454     1454              
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <70.73%> (-0.01%) ⬇️
windows-2022_Python-3.10 81.00% <70.73%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Many thanks.

@vinnamkim vinnamkim merged commit 1f8e1e7 into openvinotoolkit:develop Jul 24, 2024
7 of 8 checks passed
@vinnamkim vinnamkim deleted the enhance-cli-format-helper branch July 24, 2024 01:01
@yunchu yunchu added this to the 1.9.0 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants