Add video frames extractor and split_video command #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 15, 2021 18:35
added 11 commits
December 27, 2021 17:34
zhiltsov-max
changed the title
datumaro/components/media_manager.py
Outdated
Comment on lines
56
to
59
| def push(self, key, media): | ||
| if self.capacity <= len(self.items): | ||
| self.items.popitem(last=True) | ||
| self.items[key] = media |
There was a problem hiding this comment.
Why here is no required to close item that was removed?
There was a problem hiding this comment.
Yes, it needs. Thanks.
Comment on lines
+10
to
+13
| Splits a video into separate frames and saves them in a directory. | ||
| After the splitting, the images can be added into a project using | ||
| the [`import` command](./sources/#source-import) and the `image_dir` format. | ||
|
|
There was a problem hiding this comment.
I see that split_video -> image_dir and video_frames that two alternative approaches to import video dataset.
Maybe it will be useful to add import argument --subset for image_dir format to make these approaches fully alternative
There was a problem hiding this comment.
The both have this parameter. Do you mean, in CLI?
zhiltsov-max
force-pushed
the
zm/video-extractor
branch
2 times, most recently
from
b76916a
to
5c2b9d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
datum util split_videocommand to split videoMediaManagerclass (TBD: removeImageCache)datum importvideo_framessource produces a warning about unstable resultsadd,importandexportwithout a projectmake_dataseton empty project tree now properly produces the errorimage_dirformat extractor:--subsetCLI parameterextsanddepthparametersTBD / Problems:
ProjectHow to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.