Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Check if model file exists on read model #24864

Merged
merged 29 commits into from
Jul 3, 2024
Merged

[core] Check if model file exists on read model #24864

merged 29 commits into from
Jul 3, 2024

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Jun 5, 2024

Details:

  • Add more detailed error messages when model and/or weights files not exist at path

Tickets:

@praasz praasz added this to the 2024.3 milestone Jun 5, 2024
@praasz praasz requested a review from a team as a code owner June 5, 2024 12:15
@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label Jun 5, 2024
t-jankowski
t-jankowski requested changes Jun 5, 2024
View reviewed changes
src/inference/tests/unit/core.cpp Outdated Show resolved Hide resolved
src/inference/tests/unit/core.cpp Outdated Show resolved Hide resolved
src/inference/src/model_reader.cpp Outdated Show resolved Hide resolved
src/inference/src/model_reader.cpp Outdated Show resolved Hide resolved
@ilya-lavrenov @t-jankowski
Apply suggestions from code review
b87dc78 
Co-authored-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@ilya-lavrenov ilya-lavrenov self-assigned this Jun 5, 2024
@praasz praasz requested review from a team as code owners June 13, 2024 11:47
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: build OpenVINO cmake script / infra category: IR FE OpenVINO IR v10 / v11 FrontEnd category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: CPP API OpenVINO CPP API bindings category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Jun 13, 2024
@praasz praasz force-pushed the improve-error-msg-when-model-no-found-on-disk branch from b46efd9 to 293bc1d Compare June 26, 2024 11:00
@praasz praasz requested a review from a team as a code owner July 1, 2024 05:38
@github-actions github-actions bot added the category: MO Model Optimizer label Jul 1, 2024
@praasz praasz requested a review from a team as a code owner July 1, 2024 18:04
@mlukasze mlukasze added this pull request to the merge queue Jul 3, 2024
Merged via the queue into openvinotoolkit:master with commit 4282043 Jul 3, 2024
123 checks passed
@praasz praasz deleted the improve-error-msg-when-model-no-found-on-disk branch July 3, 2024 11:39
This was referenced Jul 12, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 12, 2024
@praasz
Revert "OVCore to check for symlinks before opening files (#24781)" (#…
5e46ffa 
…25543)

### Details:
 - This reverts commit a904d9b.
- In the #24864, the FEs check if file can be opened at given path. If
not possible then there is exception.
  
### Tickets:
 - CVS-146678
 - Relates to CVS-142055
github-merge-queue bot pushed a commit that referenced this pull request Jul 16, 2024
@praasz
Revert "OVCore to check for symlinks before opening files (#24781)" (#…
46267ef 
…25542)

### Details:
 - This reverts commit a904d9b.
- In the #24864, the FEs check if file can be opened at given path. If
not possible then there is exception.
  
### Tickets:
 - CVS-146678
 - Relates to CVS-142055
spran180 pushed a commit to spran180/openvino that referenced this pull request Jul 27, 2024
@praasz @spran180
Revert "OVCore to check for symlinks before opening files (openvinoto…
a352e46 
…olkit#24781)" (openvinotoolkit#25542)

### Details:
 - This reverts commit a904d9b.
- In the openvinotoolkit#24864, the FEs check if file can be opened at given path. If
not possible then there is exception.
  
### Tickets:
 - CVS-146678
 - Relates to CVS-142055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@barnasm1 barnasm1 Awaiting requested review from barnasm1

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: build OpenVINO cmake script / infra category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: IR FE OpenVINO IR v10 / v11 FrontEnd category: MO Model Optimizer category: ONNX FE OpenVINO ONNX FrontEnd category: PDPD FE OpenVINO PaddlePaddle FrontEnd category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd
Projects
None yet
Milestone
2024.3
Development

Successfully merging this pull request may close these issues.
4 participants
@praasz @ilya-lavrenov @t-jankowski @mlukasze