[IR] Changed RT Info nodes naming (compatible with an old) #25159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
praasz
reviewed
Jun 24, 2024
slyalin
reviewed
Jun 25, 2024
slyalin
requested changes
Jun 27, 2024
gkrivor
force-pushed
the
core_xml_names
branch
2 times, most recently
from
c0ea146
to
2cf4424
Compare
slyalin
approved these changes
Jul 8, 2024
Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>
Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>
Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>
Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>
praasz
approved these changes
Jul 8, 2024
praasz
reviewed
Jul 8, 2024
Comment on lines
+889
to
+896
| if (name.length() == 0) { | ||
| return false; | ||
| } | ||
| if (!std::all_of(name.begin(), name.end(), [](const int c) { | ||
| return std::isalnum(c) || (c == '_') || (c == '-') || (c == '.'); | ||
| })) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (name.length() == 0) { | |
| return false; | |
| } | |
| if (!std::all_of(name.begin(), name.end(), [](const int c) { | |
| return std::isalnum(c) || (c == '_') || (c == '-') || (c == '.'); | |
| })) { | |
| return false; | |
| } | |
| if (!std::all_of(name.begin(), name.end(), [](const int c) { | |
| return std::isalnum(c) || (c == '_') || (c == '-') || (c == '.'); | |
| })) { | |
| return false; | |
| } |
For empty string std::all_of should return false also.
There was a problem hiding this comment.
You are right, I just prefer explicit check :) I think I'll move it near name[0] access, just to prevent issues in case of reordering in the future. If this build fails - I'll apply, if ok - change as a separate pr
There was a problem hiding this comment.
No, std::all_of for an empty sequence returns true.
spran180
pushed a commit
to spran180/openvino
that referenced
this pull request
Jul 27, 2024
…oolkit#25159) ### Details: - Fixed an xml serialization/deserialization in case name isn't xml-compatible ### Tickets: - 131514 --------- Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: