Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Add specific tensor descriptor for Result #25954

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open

[core] Add specific tensor descriptor for Result #25954

wants to merge 37 commits into from
+782 −289

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Aug 7, 2024 •
edited
Loading

Details:

  • Introduce shared tensor descriptor:

    • It has specific tensor names.
    • When specific tensor names set they will be used as tensor names otherwise the shred tensor names are used.
    • Specific tensor names will be added to shared descriptor (input descriptor), and transferred to new tensor descriptor if changed.

  • Use shared tensor descriptor for Result, which got specific tensor names.

  • Add dev API Extension interface for descriptor::Tensor for internal OV use.

  • Update ReverseShapeAndTypeInfer to use descriptor interface instead change properties directly. Update PartialShape of descriptor can change it in undefined state with Shape property.

  • Improves tensor names handling for model outputs introduced in [core] Preserve friendly name and tensor names in PPP #23713

Tickets:

Depends on:

  • intel-innersource/frameworks.ai.openvino.tests#1650 - fixes e2e tests

@praasz praasz added WIP work in progress do_not_review labels Aug 7, 2024
@praasz praasz requested review from a team as code owners August 7, 2024 11:42
@praasz praasz requested review from itikhono and removed request for a team August 7, 2024 11:42
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) category: transformations OpenVINO Runtime library - Transformations category: CPP API OpenVINO CPP API bindings labels Aug 7, 2024
@praasz praasz requested a review from t-jankowski August 7, 2024 12:49
@praasz praasz added this to the 2024.4 milestone Aug 7, 2024
@praasz praasz requested review from a team as code owners August 9, 2024 11:37
@github-actions github-actions bot added the category: MO Model Optimizer label Aug 9, 2024
@praasz praasz requested a review from a team as a code owner August 19, 2024 12:24
@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend labels Aug 19, 2024
@olpipi olpipi force-pushed the feature/specific-tensor-descriptor-for-results branch from 8f8b5a4 to 1b7eedf Compare August 28, 2024 10:20
rkazants
rkazants requested changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why several tensor names are not clear

@github-actions github-actions bot added the category: JAX FE OpenVINO JAX FrontEnd label Sep 13, 2024
@github-actions github-actions bot removed the category: MO Model Optimizer label Sep 17, 2024
@praasz praasz removed the WIP work in progress label Sep 17, 2024
@praasz praasz requested a review from olpipi September 17, 2024 10:05
@praasz praasz mentioned this pull request Sep 17, 2024
Open
@praasz praasz modified the milestones: 2024.4, 2024.5 Sep 20, 2024
t-jankowski
t-jankowski reviewed Sep 24, 2024
View reviewed changes
src/core/tests/type_prop/result.cpp Outdated Show resolved Hide resolved
src/core/include/openvino/core/descriptor/tensor.hpp Outdated Show resolved Hide resolved
src/core/include/openvino/core/descriptor/tensor.hpp Outdated Show resolved Hide resolved
src/core/src/descriptor/tensor.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-jankowski t-jankowski t-jankowski approved these changes

@itikhono itikhono Awaiting requested review from itikhono itikhono is a code owner automatically assigned from openvinotoolkit/openvino-ie-transformations-maintainers

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

@slyalin slyalin Awaiting requested review from slyalin

@rkazants rkazants Awaiting requested review from rkazants

@alexsu52 alexsu52 Awaiting requested review from alexsu52

@olpipi olpipi Awaiting requested review from olpipi

Requested changes must be addressed to merge this pull request.

Assignees

@ilya-lavrenov ilya-lavrenov

@alexsu52 alexsu52

@slyalin slyalin

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: inference OpenVINO Runtime library - Inference category: JAX FE OpenVINO JAX FrontEnd category: PyTorch FE OpenVINO PyTorch Frontend category: TF FE OpenVINO TensorFlow FrontEnd category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
6 participants
@praasz @rkazants @t-jankowski @ilya-lavrenov @alexsu52 @slyalin