Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numpy==1.26 in MO for Python 3.12 enablement #26118

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented Aug 19, 2024

Details:

  • numpy==1.27 is the first version to support Python 3.12
  • kaldi, mxnet and caffee will most likely fail with Python 3.12, TBD how to handle it
  • cc @culhatsker

Tickets:

@p-wysocki p-wysocki requested a review from a team as a code owner August 19, 2024 13:08
@p-wysocki p-wysocki requested review from akuporos and artanokhov and removed request for a team August 19, 2024 13:08
@github-actions github-actions bot added category: MO Model Optimizer category: dependency_changes Pull requests that update a dependency file labels Aug 19, 2024
@culhatsker
Copy link
Contributor

Can we update numpy for MXNET also or is it not working for Python3.12?

@rkazants
Copy link
Contributor

rkazants commented Aug 20, 2024

@p-wysocki, PR title is slightly confusing. I think you disallow use of numpy 1.27 for openvino-dev. Please clarify

@p-wysocki p-wysocki changed the title Allow numpy==1.27 in MO for Python 3.12 enablement Allow numpy==1.26 in MO for Python 3.12 enablement Aug 20, 2024
@p-wysocki
Copy link
Contributor Author

@p-wysocki, PR title is slightly confusing. I think you disallow use of numpy 1.27 for openvino-dev. Please clarify

@rkazants you were right, there was an error in the PR title. This PR enables 1.26, not 1.27. Fixed.

@p-wysocki
Copy link
Contributor Author

Can we update numpy for MXNET also or is it not working for Python3.12?

@culhatsker since mxnet is an archived project the CI could blow up, but I bumped it.

@p-wysocki p-wysocki added this to the 2024.4 milestone Aug 21, 2024
@culhatsker
Copy link
Contributor

Looks ok to me👍

@akuporos akuporos added this pull request to the merge queue Aug 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 22, 2024
### Details:
 - `numpy==1.27` is the first version to support Python 3.12
- kaldi, mxnet and caffee will most likely fail with Python 3.12, TBD
how to handle it
 - cc @culhatsker 

### Tickets:
 - CVS-150017
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2024
@p-wysocki p-wysocki added this pull request to the merge queue Aug 22, 2024
Merged via the queue into openvinotoolkit:master with commit 45a6f33 Aug 22, 2024
127 checks passed
@p-wysocki p-wysocki deleted the bump_numpy branch August 22, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: dependency_changes Pull requests that update a dependency file category: MO Model Optimizer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants