Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyOV] Fix segfault when constructing std::string and using GPU Plugin #26121

Closed
wants to merge 20 commits into from

Conversation

p-wysocki
Copy link
Contributor

Details:

  • Details and investigation in the ticket
  • I confirmed locally that the GPU fix does not break CPU
  • Let's wait for CIs to run for final fix confirmation

Tickets:

@p-wysocki p-wysocki requested review from a team as code owners August 19, 2024 14:08
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: TF FE OpenVINO TensorFlow FrontEnd labels Aug 19, 2024
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of tests are failing. Not sure that the fix is correct.
@davidsnam-intel, fyi.

@p-wysocki p-wysocki added this to the 2024.4 milestone Aug 21, 2024
@akuporos akuporos modified the milestones: 2024.4, 2024.5 Sep 3, 2024
@p-wysocki
Copy link
Contributor Author

After further investigation described in CVS-148921 it seems that the GPU Tensors cannot handle empty strings and the fix should be done in a different PR.

@p-wysocki p-wysocki closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Python API OpenVINO Python bindings category: TF FE OpenVINO TensorFlow FrontEnd do_not_review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants