Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyOV] Fix segfault when constructing std::string and using GPU Plugin #26121

Closed
wants to merge 20 commits into from
Closed

[PyOV] Fix segfault when constructing std::string and using GPU Plugin #26121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
10c3086
Fix segfault
p-wysocki Aug 19, 2024
15cd31f
Debug
p-wysocki Aug 20, 2024
8726379
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
p-wysocki Sep 6, 2024
0988100
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
p-wysocki Sep 11, 2024
79d8222
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
p-wysocki Sep 12, 2024
6440f11
Debug fix
p-wysocki Sep 12, 2024
75380f1
Cleanup
p-wysocki Sep 12, 2024
c3ee56a
Debug
p-wysocki Sep 12, 2024
d0a0080
Merge branch 'master' of https://github.com/openvinotoolkit/openvino …
p-wysocki Sep 17, 2024
6d6980f
Change ctor
p-wysocki Sep 17, 2024
77a6138
Change Python assignment operation
p-wysocki Sep 18, 2024
4d932e2
Minor change
p-wysocki Sep 18, 2024
32f9335
Adjust logic for byte strings
p-wysocki Sep 18, 2024
423a94b
Minor change
p-wysocki Sep 18, 2024
f45a57a
Fix flake
p-wysocki Sep 18, 2024
17f2618
Fix mypy
p-wysocki Sep 18, 2024
b9bb130
Logic for U17
p-wysocki Sep 18, 2024
dccf3a5
Minor change
p-wysocki Sep 18, 2024
af81cf1
Add logic for F_CONTIGUOUS
p-wysocki Sep 18, 2024
cf7cb49
Merge branch 'master' into segfault_py
akuporos Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bindings/python/src/pyopenvino/core/common.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void fill_tensor_from_strings(ov::Tensor& tensor, py::array& array) {
PyUnicode_FromKindAndData(PyUnicode_4BYTE_KIND, reinterpret_cast<void*>(ptr), buf.itemsize / 4);
PyObject* _utf8_obj = PyUnicode_AsUTF8String(_unicode_obj);
const char* _tmp_str = PyBytes_AsString(_utf8_obj);
data[i] = std::string(_tmp_str);
data[i] = std::string(_tmp_str, buf.ndim == 0 ? buf.itemsize : buf.strides[0]);
Py_XDECREF(_unicode_obj);
Py_XDECREF(_utf8_obj);
}
Expand Down
3 changes: 0 additions & 3 deletions tests/layer_tests/tensorflow_tests/test_tf_LookupTableSize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ def create_lookup_table_size_net(self, hash_table_type, keys_type, values_type,
@pytest.mark.nightly
def test_lookup_table_size(self, hash_table_type, params, ie_device, precision, ir_version, temp_dir,
use_legacy_frontend):
keys_type = params['keys_type']
if ie_device == 'GPU' and keys_type == str:
pytest.skip("148921: Segmentation fault on GPU")
self._test(*self.create_lookup_table_size_net(hash_table_type=hash_table_type, **params),
ie_device, precision, ir_version, temp_dir=temp_dir,
use_legacy_frontend=use_legacy_frontend)
Loading