Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Improve Constant get_vector for low precisions #26177

Merged
merged 5 commits into from
Sep 18, 2024
Merged

[core] Improve Constant get_vector for low precisions #26177

merged 5 commits into from
Sep 18, 2024

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Aug 22, 2024

Details:

  • The Constant get_vector works correctly for low precisions.
  • Initialize not used bits in Constant buffer for low precisions to avoid undefined values.

Tickets:

@praasz praasz added this to the 2024.4 milestone Aug 22, 2024
@praasz praasz requested a review from a team as a code owner August 22, 2024 09:17
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings labels Aug 22, 2024
@praasz praasz mentioned this pull request Aug 22, 2024
Closed
@TolyaTalamanov
Copy link
Contributor

Hi @praasz the problem is still reproducible on my end, let's discuss this locally

@mlukasze mlukasze added the no_stale Do not mark as stale label Sep 3, 2024
@mlukasze mlukasze modified the milestones: 2024.4, 2024.5 Sep 3, 2024
@praasz praasz requested a review from a team as a code owner September 10, 2024 13:19
@github-actions github-actions bot added the category: IR FE OpenVINO IR v10 / v11 FrontEnd label Sep 10, 2024
@praasz praasz added this pull request to the merge queue Sep 18, 2024
Merged via the queue into openvinotoolkit:master with commit b1cd3aa Sep 18, 2024
151 checks passed
@praasz praasz deleted the improve-constant-get-vector-for-low-precision branch September 18, 2024 15:02
@praasz praasz removed the no_stale Do not mark as stale label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@TolyaTalamanov TolyaTalamanov

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: IR FE OpenVINO IR v10 / v11 FrontEnd
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
5 participants
@praasz @TolyaTalamanov @ilya-lavrenov @t-jankowski @mlukasze