[Snippets] Introduced BufferExpression #26413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
1c46e4d
to
4d607ea
Compare
a-sidorova
commented
Sep 5, 2024
| const char* get_type_name() const { | ||
| return get_type_info().name; | ||
| } | ||
|
|
||
| protected: | ||
| Expression(const Expression& other); | ||
| // Note: The constructor initialization is private since an expression can be created only by Linear IR. | ||
| // The method must be used only by Linear IR builder of expressions! | ||
| Expression(const std::shared_ptr<Node>& n, const std::shared_ptr<IShapeInferSnippetsFactory>& factory, bool need_shape_infer = true); |
There was a problem hiding this comment.
Open question for discussion: can we move this ctor to public section to avoid writing friend class ExpressionFactory; in each SpecialExpression 🤔
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
2 times, most recently
from
3a82f13
to
b6daa85
Compare
v-Golubev
reviewed
Sep 6, 2024
src/common/snippets/include/snippets/lowered/expressions/buffer_expression.hpp
Outdated
Show resolved
Hide resolved
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
a658924
to
aa70468
Compare
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
aa70468
to
e34be5a
Compare
1 task
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
d8d532a
to
48525c4
Compare
v-Golubev
reviewed
Sep 11, 2024
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
48525c4
to
0432d44
Compare
2 tasks
| // IntermediateMemoryImpl represents intermediate memory. | ||
| // The buffers with this implementation must have source (parents) | ||
| class IntermediateMemoryImpl : public BaseImpl { | ||
| class ShapeInfer; |
There was a problem hiding this comment.
Minor: this class is used only in implementations, forward declaration is not required.
There was a problem hiding this comment.
Correct, Looks like it's remainder after the previous implementations. Removed
src/plugins/intel_cpu/src/emitters/snippets/aarch64/jit_kernel_emitter.cpp
Outdated
Show resolved
Hide resolved
...ins/intel_cpu/src/transformations/snippets/x64/pass/lowered/insert_brgemm_copy_b_buffers.hpp
Outdated
Show resolved
Hide resolved
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
c6bc187
to
719256d
Compare
|
@IvanNovoselov your comments have been applied. May I ask you please to take a look one more time? |
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
719256d
to
37a62e4
Compare
[Snippets][CPU] Implemented BrgemmCopyB specific buffers [Snippets] Fixed build
a-sidorova
force-pushed
the
feature/snippets/buffer_expr
branch
from
37a62e4
to
16568a6
Compare
IvanNovoselov
approved these changes
Sep 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
### Details: - *Implemented BrgemmCopyBExecutor* - *Added tests with dynamic input shapes for MatMul INT8/BF16* ### Tickets: - *151922* ### Prerequisites: - [x] #26413
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
BufferExpression- now we don't have to cast the source node toop::Bufferto get attributes - all of them are stored inBufferExpressionnowNewMemoryBufferandIntermediateMemoryBufferops into oneBuffersince now they are distinguished only by argument countBrgemmCopyB-specificBufferExpressionafter this opTickets: