Fix path to generated ov_plugins.hpp #26521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenVino fails to compile if it's used as a subdirectory in CMakeLists.txt. For example, below scenario: ``` $ git clone https://github.com/openvinotoolkit/openvino --recursive $ cat CMakeLists.txt project(testing) add_subdirectory(openvino) $ mkdir build $ cmake -B build -S . $ make -C build openvino_runtime_obj ``` ends with compilation error: ``` core_impl.cpp:32:10: fatal error: ov_plugins.hpp: No such file or directory 32 | #include "ov_plugins.hpp" | ^~~~~~~~~~~~~~~~ ``` because of incorrect include path. openvino_runtime_obj target expects ov_plugins.hpp to be present in ${CMAKE_CURRENT_BINARY_DIR} (which is build/openvino/src/inference in this case), but ov_plugins.hpp is generated to ${CMAKE_BINARY_DIR}/src/inference (which is build/src/inference). To fix that, ov_generate_plugins_hpp can use BINARY_DIR property of openvino_runtime_obj instead of ${CMAKE_BINARY_DIR}/src/inference.
ilya-lavrenov
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenVino fails to compile if it's used as a subdirectory in CMakeLists.txt. For example, below scenario:
ends with compilation error:
because of incorrect include path.
openvino_runtime_obj target expects ov_plugins.hpp to be present in ${CMAKE_CURRENT_BINARY_DIR} (which is build/openvino/src/inference in this case), but ov_plugins.hpp is generated to ${CMAKE_BINARY_DIR}/src/inference (which is build/src/inference). To fix that, ov_generate_plugins_hpp can use BINARY_DIR property of openvino_runtime_obj instead of ${CMAKE_BINARY_DIR}/src/inference.