Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GHA] Enable thread sanitizer #26634

Open
wants to merge 73 commits into
base: master
Choose a base branch
from
Open

[GHA] Enable thread sanitizer #26634

wants to merge 73 commits into from
+215 −108

Conversation

mryzhov
Copy link
Contributor

@mryzhov mryzhov commented Sep 17, 2024 •
edited
Loading

Details:

  • Enable thread sanitizer
  • Fixed protobuf build

Tickets:

  • ticket-id

@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code category: build OpenVINO cmake script / infra no-match-files labels Sep 17, 2024
@mryzhov mryzhov mentioned this pull request Sep 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 23, 2024
@mryzhov
[GHA] Enable UndefinedBehavior sanitizer (#26736)
17f976d 
### Details:
 - Tested in #26634

### Tickets:
 - *144163*
@github-actions github-actions bot added the category: dependency_changes Pull requests that update a dependency file label Sep 23, 2024
@github-actions github-actions bot removed the category: dependency_changes Pull requests that update a dependency file label Sep 23, 2024
@mryzhov mryzhov force-pushed the gha/sanitizers branch 2 times, most recently from 841a2b5 to 1a01805 Compare September 23, 2024 19:06
@github-actions github-actions bot added the category: dependency_changes Pull requests that update a dependency file label Sep 23, 2024
@mryzhov mryzhov changed the title [TEST][GHA] Enable all sanitizers builds [GHA] Enable thread sanitizer Sep 24, 2024
@mryzhov mryzhov marked this pull request as ready for review September 24, 2024 08:57
@mryzhov mryzhov requested review from a team as code owners September 24, 2024 08:57
akashchi
akashchi approved these changes Sep 24, 2024
View reviewed changes
.github/workflows/linux_sanitizers.yml
Comment on lines +7 to +10
pull_request:
branches:
- master
- 'releases/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to comment out.

.github/workflows/linux_sanitizers.yml Outdated
@@ -38,8 +41,8 @@ jobs:
SANITIZER_CMAKE_OPTION: '-DENABLE_SANITIZER=ON'
- SANITIZER: 'UndefinedBehavior'
SANITIZER_CMAKE_OPTION: '-DENABLE_UB_SANITIZER=ON'
# - SANITIZER: 'Thread' # Problems with protobuf
# SANITIZER_CMAKE_OPTION: '-DENABLE_THREAD_SANITIZER=ON'
- SANITIZER: 'Thread' # Problems with protobuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment could be removed.

@mryzhov mryzhov requested review from a team as code owners September 25, 2024 12:03
@github-actions github-actions bot added category: NPU OpenVINO NPU plugin and removed category: NPU OpenVINO NPU plugin labels Sep 25, 2024
akashchi
akashchi reviewed Sep 26, 2024
View reviewed changes
.github/workflows/linux_sanitizers.yml Outdated Show resolved Hide resolved
.github/dockerfiles/ov_build/ubuntu_20_04_x64/Dockerfile
Comment on lines +34 to +35
clang \
lld \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since a dedicated image is used, I think these changes could be reverted.

@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Sep 30, 2024
@github-actions github-actions bot removed the category: NPU OpenVINO NPU plugin label Sep 30, 2024
@github-actions github-actions bot added the category: NPU OpenVINO NPU plugin label Oct 1, 2024
@github-actions github-actions bot removed the category: NPU OpenVINO NPU plugin label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashchi akashchi akashchi approved these changes

@ilya-lavrenov ilya-lavrenov Awaiting requested review from ilya-lavrenov

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: dependency_changes Pull requests that update a dependency file category: dockerfiles github_actions Pull requests that update GitHub Actions code no-match-files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mryzhov @akashchi