Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyOV] Deprecate comparison for operations #26761

Merged

Conversation

akuporos
Copy link
Contributor

@akuporos akuporos commented Sep 24, 2024

Details:

  • [PyOV] __eq__ for parameter and result #26613 caused backward incompatible changes, so decided to deprecate comparison overloads for comparison operations as the usage of them confuse users
  • suppress deprecation warnings in tests
  • added bindings for get_instance_id() to Node class

Tickets:

@akuporos akuporos requested a review from a team as a code owner September 24, 2024 12:35
@akuporos akuporos added this to the 2024.5 milestone Sep 24, 2024
@github-actions github-actions bot added the category: Python API OpenVINO Python bindings label Sep 24, 2024
@akuporos akuporos force-pushed the akup/deprecate-binary-op-overloads branch from af42ff8 to feffce3 Compare September 24, 2024 12:40
node.def("get_instance_id",
&ov::Node::get_instance_id,
R"(
Returns id of the node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more info about why they may want to get node id (for comparison)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@akuporos akuporos added this pull request to the merge queue Sep 27, 2024
Merged via the queue into openvinotoolkit:master with commit 3eddb07 Sep 27, 2024
152 checks passed
@akuporos akuporos deleted the akup/deprecate-binary-op-overloads branch September 27, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Python API OpenVINO Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants