List decompositions for torch.export #26878
Conversation
github-actions
bot
added
category: Python API
| def get_export_decomposition_list(): | ||
| # List of decompositions from torch._decomp.core_aten_decompositions | ||
| # removed _backward ops and ops supported without decomposition | ||
| decomp = [ |
There was a problem hiding this comment.
How are we going to maintain this list from one version to another?
Should we really need it for models conversion or is it for NNCF tool only?
There was a problem hiding this comment.
This list changes not very often, we do not really need to always have it up to date. We may even reduce it in future. The main reason this list is needed is that SDPA gets decomposed by default but we want it to exist as a single operation.
There was a problem hiding this comment.
Can we check in the test that SDPA op is really created in the original graph?
There was a problem hiding this comment.
The decompositions happen inside convert_model. Checking that operation exist would require patching ovc, also would need to decide how to split ts ops from fx ops when writing a test. This solution is outside of scope of this PR. I suggest solving that with a different PR
Details:
Tickets: