-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPUW: Bring back unpack and partitioning unit tests for NPUW #26885
NPUW: Bring back unpack and partitioning unit tests for NPUW #26885
Conversation
#if 0 | ||
#include "unpack.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may trigger a warning but let's see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's enable tests if only AVX2 is present (check via #ifdef)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Added #ifdef __AVX2__
#if 0 | ||
#include "unpack.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's enable tests if only AVX2 is present (check via #ifdef)
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
|
||
#ifdef __AVX2__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilya-lavrenov is that the right way to detect AVX2, or OpenVINO comes with its own compile definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmatveev i think we should stick to openvino form or forced disabling based on cmake configs in form of one of macro
set(_DEFINE_SSE42 "HAVE_SSE42" ${_DEFINE_ANY})
set(_DEFINE_AVX "HAVE_AVX" ${_DEFINE_SSE42})
set(_DEFINE_AVX2 "HAVE_AVX2" ${_DEFINE_AVX})
set(_DEFINE_AVX512F "HAVE_AVX512F" ${_DEFINE_AVX2})
for our tests, #ifdef HAVE_AVX2 should be enough, while tests code itself can be rewritten in ref without intrinsics,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be HAVE_AVX2
Removed from auto-merge, two builds are failing |
All builds are green, adding to auto-merge |
This PR adds unit tests on
Brings back #25780
Local run: