[core] Constant can be created as from shared memory #26901
+154
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
t-jankowski
approved these changes
Oct 3, 2024
| @@ -186,6 +186,24 @@ class OPENVINO_API Constant : public Op { | |||
| /// \param data A void* to constant data. | |||
| Constant(const element::Type& type, const Shape& shape, const void* data); | |||
|
|
|||
| /// \brief Construct a tensor constant from shared memory. | |||
| /// | |||
| /// The constant byte size (defined by type and shape) must be lower than shred memory size, otherwise throw | |||
There was a problem hiding this comment.
Suggested change
| /// The constant byte size (defined by type and shape) must be lower than shred memory size, otherwise throw | |
| /// The constant byte size (defined by type and shape) must be lower than shared memory size, otherwise throw |
Comment on lines
+193
to
+194
| /// The Constant can take ownership of shared memory if provided shared object is not null pointer manges memory | ||
| /// lifetime. |
There was a problem hiding this comment.
Suggested change
| /// The Constant can take ownership of shared memory if provided shared object is not null pointer manges memory | |
| /// lifetime. | |
| /// The Constant can take ownership of shared memory if provided shared object is not null and manages memory | |
| /// lifetime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Related PR:
Tickets: