Use get_partial_shape to get dynamic shape #26907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PatrikStepan @pereanub @XinWangIntel can you please have a look? |
DariaMityagina
approved these changes
Oct 4, 2024
| @@ -278,7 +277,7 @@ std::string LevelZeroCompilerInDriver<TableExtension>::serializeIOInfo(const std | |||
|
|
|||
| for (const std::shared_ptr<ov::op::v0::Parameter>& parameter : parameters) { | |||
| const ov::element::Type& precision = parameter->get_element_type(); | |||
| const size_t rank = parameter->get_shape().size(); | |||
| const size_t rank = parameter->get_partial_shape().size(); | |||
There was a problem hiding this comment.
rank can also be dynamic
There was a problem hiding this comment.
@ArtemySkrebkov, do we need a throw for such cases? I'm pretty sure that we don't support this.
There was a problem hiding this comment.
Yep, we do not support dynamic rank.
Added a throw for this case.
Previously, I thought to rely on PartialShape::size to throw (there is an assert for dynamic rank), but having a more precise error message sounds good to me too.
pereanub
approved these changes
Oct 7, 2024
Maxim-Doronin
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
get_shapewill throw if called on dynamic shapeTickets: