Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert personality txt files to yaml, replace print with log, and update app.py #144

Merged
merged 11 commits into from
Jan 7, 2025

Conversation

zhuo-yoyowz
Copy link
Contributor

Convert personality txt files to yaml, and update app.py

@zhuo-yoyowz zhuo-yoyowz changed the title Convert personality txt files to yaml, and update app.py Convert personality txt files to yaml, replace print with log, and update app.py Dec 19, 2024
Copy link
Contributor

@adrianboguszewski adrianboguszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension change isn't enough for supporting yaml, because in code it still behaves as txt.
Please look at the virtual AI assistant, how yaml files are handled :)

@zhuo-yoyowz
Copy link
Contributor Author

Thanks for the comment! Updated the yaml file, according to the virtual AI assistant demo. Please help review again. Thanks!

@adrianboguszewski
Copy link
Contributor

It still won't work as expected. YAML files must be read through the yaml library. Once again, check the virtual AI assistant for loading and handling the content of the file.

@zhuo-yoyowz
Copy link
Contributor Author

Updated codes with YAML way to load the personality file. Please help review. Thank you!

@adrianboguszewski adrianboguszewski merged commit 7e76caf into openvinotoolkit:master Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants