Revert "LLAMA_CPP plugin - basic version with direct file loading" #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 8759969.
github-actions
bot
added
category: build
|
maybe we need to exclude it from GHA builds in OV repo? |
It also breaks Jenkins, so we'll need to make hot fixes everywhere. As far as I understand, the expectation was for this plugin to not be registered automatically at all |
plugin is not registered in runtime, but compilation is still here.. Looks like we need to implement mechanism to turn off by default new modules, until they are explicitly enabled in Jenkins / GHA |
|
Merged revert until either explicit disabling of the new plugin is applied to all affected pipelines; or the mechanism to turn off new modules by default is implemented on cmake side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #891
Breaks OV CI: https://github.com/openvinotoolkit/openvino/actions/runs/8433435988/job/23095410754?pr=23683