Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agentic-RAG notebooks with LlamaIndex #2189

Merged
merged 12 commits into from
Jul 17, 2024

Conversation

openvino-dev-samples
Copy link
Collaborator

@openvino-dev-samples openvino-dev-samples commented Jul 11, 2024

TODO

  • add gradio demo

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@openvino-dev-samples openvino-dev-samples changed the title Add Agentic-RAG notebooks Add Agentic-RAG notebooks with LlamaIndex Jul 11, 2024
@@ -0,0 +1,597 @@
{
Copy link
Collaborator

@eaidova eaidova Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to have this in cell, but commented like here https://github.com/openvinotoolkit/openvino_notebooks/blob/latest/notebooks/stable-diffusion-v3/stable-diffusion-v3.ipynb

or if possible to use some model that does not required gated access


Reply via ReviewNB

@@ -531,4 +531,10 @@
- ubuntu-20.04
- ubuntu-22.04
- windows-2019

- notebook: notebooks/llm-agent-react/llm-agent-rag-llamaindex.ipynb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OpenVINO-dev-contest is it possible to setup replacement with some smaller model for tests only? e.g. tiny-llama or qwen2 (we do not need to check generation quality, more about checking that notebook is functional

fix ci issue

update test case
openvino-dev-samples and others added 2 commits July 15, 2024 17:50
Co-authored-by: Ekaterina Aidova <ekaterina.aidova@intel.com>
Co-authored-by: Ekaterina Aidova <ekaterina.aidova@intel.com>
@openvino-dev-samples
Copy link
Collaborator Author

no idea why CI failed on Llama_index import, cuz it works fine with my clean environment.

@eaidova
Copy link
Collaborator

eaidova commented Jul 16, 2024

@OpenVINO-dev-contest which python version do you use for testing? I have suspicious that some of packages can be non available for python3.8 (deprecated version, some packages already exclude it from supported)

Could you please try to add it into ignored for python3.8 only?

@openvino-dev-samples
Copy link
Collaborator Author

@OpenVINO-dev-contest which python version do you use for testing? I have suspicious that some of packages can be non available for python3.8 (deprecated version, some packages already exclude it from supported)

Could you please try to add it into ignored for python3.8 only?

Python 3.11

@eaidova eaidova merged commit 7e86114 into openvinotoolkit:latest Jul 17, 2024
9 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants