Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phi-3.5-vision-instruct model #2385

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

yatarkan
Copy link
Collaborator

@yatarkan yatarkan commented Sep 12, 2024

Ticket: CVS-152268

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Sep 12, 2024

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2024-09-12T12:33:25Z
----------------------------------------------------------------

>The Phi-3-Vision-128K-Instruct is a lightweight, state-of-the-art open multimodal model built upon datasets which include - synthetic data and filtered publicly available websites - with a focus on very high-quality, reasoning dense data both on text and vision.

Please remove link and change Phi-3-Vision-128k-instruct to Phi-3-vision


Copy link

review-notebook-app bot commented Sep 12, 2024

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2024-09-12T12:35:19Z
----------------------------------------------------------------

Line #4.    if not Path("ov_phi3_vision.py").exists():

could you please rename this file per our yesterday agreement (ov_phi3_vision_helper.py)?


Copy link

review-notebook-app bot commented Sep 12, 2024

View / edit / reply to this conversation on ReviewNB

eaidova commented on 2024-09-12T15:23:12Z
----------------------------------------------------------------

ov_phi3_model.py script contains helper function for model conversion, please check its content if you interested in conversion details.

ov_phi3_model.py -> ov_phi3_vision_helper.py


@eaidova eaidova merged commit 57a758c into openvinotoolkit:latest Sep 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants