Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use instance in VC Playground #28

Open
jrhender opened this issue Jun 24, 2024 · 1 comment
Open

Use instance in VC Playground #28

jrhender opened this issue Jun 24, 2024 · 1 comment

Comments

@jrhender
Copy link
Contributor

The VC Playground is a demonstration application for Verifiable Credential issuance and verification: https://vcplayground.org.
Wallets interact with a VC API instance in order to accomplish the exchanges, issuance and verification.

The VC Playground maintainers have offered to integrate this VC API implementation in the past. A challenge has previously been the use of additional LD Contexts. However, this issue may be resolved by the use of Credo for credential operations (#20).
@jrhender jrhender changed the title Include VC Playground Use instance in VC Playground Jun 24, 2024
@jrhender jrhender moved this to Todo in VC API 2024-H2 Jul 23, 2024
@jrhender
Copy link
Contributor Author

VC Playground has SVG credential rendering features: https://lists.w3.org/Archives/Public/public-credentials/2024Aug/0005.html

jrhender added a commit that referenced this issue Jan 20, 2025
@ShikharBhatt @jrhender
feat(workflows): add review endpoint (#28)
43ec237 
* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* Revert "feat: add review endpoint"

This reverts commit e93196d.

* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix: e2e tests

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* refactor: OnlyRedirect is duplicate of RedirectUrl

Signed-off-by: John Henderson <jrhender@users.noreply.github.com>

---------

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
Co-authored-by: John Henderson <jrhender@users.noreply.github.com>
jrhender added a commit that referenced this issue Jan 21, 2025
@ShikharBhatt @jrhender
feat(workflows): add review endpoint (#28)
1f9e199 
* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* Revert "feat: add review endpoint"

This reverts commit e93196d.

* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix: e2e tests

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* refactor: OnlyRedirect is duplicate of RedirectUrl

Signed-off-by: John Henderson <jrhender@users.noreply.github.com>

---------

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
Co-authored-by: John Henderson <jrhender@users.noreply.github.com>
jrhender added a commit that referenced this issue Jan 21, 2025
@ShikharBhatt @jrhender
feat(workflows): add review endpoint (#28)
36d1276 
* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* Revert "feat: add review endpoint"

This reverts commit e93196d.

* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix: e2e tests

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* refactor: OnlyRedirect is duplicate of RedirectUrl

Signed-off-by: John Henderson <jrhender@users.noreply.github.com>

---------

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
Co-authored-by: John Henderson <jrhender@users.noreply.github.com>
jrhender added a commit that referenced this issue Jan 21, 2025
@jrhender @ShikharBhatt
feat: workflows implementation (#43)
953926e 
Initial implementation of the VC API workflows functionality
https://w3c-ccg.github.io/vc-api/#workflows-and-exchanges

It is functionally very similar to the previous "exchanges".

Commit messages:

* feat: add workflow creation api

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* style: prettier on workflow files

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(workflow): initial createExchange (#14)

---------

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat: add exchange apis and minor updates

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix: create new VpRequestDefinitionDto

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* feat(workflows): sketch participateInExchange

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(workflows): fix redirectUrl in issuance step

Signed-off-by: jrhender <john.henderson@energyweb.org>

* chore: add participate in exchange

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* chore: implement participate in an exchange method

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* chore: rename entity tables

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* chore: integrate callback in participate in exchange

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* test: initial workflow e2e test (#15)

---------

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(WfExchangeEntity): rename to differentiate from ExchangeEntity

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(workflow.service): full exchangeId when creating exchange. (#18)

ExchangeId in Create Exchange response should be full URL as per spec.

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(vc-api controller): add participate in wf exchange

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(wf exchanges): participate request body

Fixing Participate Exchange request body to match the spec.

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat: exchange state apis (#20)

* feat: add exchange state apis

- exchange state api
- exchange step state api

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix(workflow.service): full exchangeId when creating exchange. (#18)

ExchangeId in Create Exchange response should be full URL as per spec.

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat: add exchange state apis

- exchange state api
- exchange step state api

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix(workflow.service): full exchangeId when creating exchange. (#18)

ExchangeId in Create Exchange response should be full URL as per spec.

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(vc-api controller): add participate in wf exchange

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(wf exchanges): participate request body

Fixing Participate Exchange request body to match the spec.

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat: add exchange state apis

- exchange state api
- exchange step state api

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix: merging conflicts

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

---------

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: jrhender <john.henderson@energyweb.org>
Signed-off-by: Shikhar Bhatt <shikhar.bhatt@impactility.com>
Co-authored-by: John Henderson <jrhender@users.noreply.github.com>
Co-authored-by: jrhender <john.henderson@energyweb.org>

* feat(wf-exchange-entity): return next action on empty participate body

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(workflow.service): pass baseUrl to entity

Signed-off-by: jrhender <john.henderson@energyweb.org>

* docs: add worfklows documentation (#23)

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix(workflow.service): remove extra slash

Signed-off-by: jrhender <john.henderson@energyweb.org>

* test(wallet-client): fix continueWorkflowExchange

Signed-off-by: jrhender <john.henderson@energyweb.org>

* test(wf-exchange.entity): using exchangeResponse to get requirements

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(wf-exchange.entity): only hydrate interact if it is queryExchangeStep

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(workflow.service): add full url as exchangeId

Signed-off-by: jrhender <john.henderson@energyweb.org>

* refactor: Fix typo in parameter name from `expectsProcessionInProgress`

Signed-off-by: jrhender <john.henderson@energyweb.org>

* refactor: Update continueWorkflowExchange method with enum-based response handling

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat: Add state field to ExchangeStep with predefined states

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(issuance-exchange): make processPresentation a no-op

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(exchange-step): remove started state. It is the same as in-progress

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat: Add markComplete method and private state with getter to ExchangeStep

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(exchange-steps): marking steps as complete when done

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(workflow-service): fix the retrieval of current step

Signed-off-by: jrhender <john.henderson@energyweb.org>

* test(workflow e2e): correcting stepIds

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix: step presentation submission persistence

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix:(wf-exchange.entity): replace current step reference after mutating

Signed-off-by: jrhender <john.henderson@energyweb.org>

* feat(workflows): add review endpoint (#28)

* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* Revert "feat: add review endpoint"

This reverts commit e93196d.

* feat: add review endpoint

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* fix: e2e tests

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* refactor: OnlyRedirect is duplicate of RedirectUrl

Signed-off-by: John Henderson <jrhender@users.noreply.github.com>

---------

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
Co-authored-by: John Henderson <jrhender@users.noreply.github.com>

* fix(workflow e2e): create correct presentation exchange

Signed-off-by: jrhender <john.henderson@energyweb.org>

* fix(workflow e2e): convert step to instance

Signed-off-by: jrhender <john.henderson@energyweb.org>

* chore: deprecate exchanges apis

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>

* style: app prettier fixes

Signed-off-by: jrhender <john.henderson@energyweb.org>

* test(vc-api.controller): fix unit test

Signed-off-by: jrhender <john.henderson@energyweb.org>

---------

Signed-off-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Signed-off-by: jrhender <john.henderson@energyweb.org>
Signed-off-by: Shikhar Bhatt <shikhar.bhatt@impactility.com>
Signed-off-by: John Henderson <jrhender@users.noreply.github.com>
Co-authored-by: ShikharBhatt <shikhar.bhatt@impactility.com>
Co-authored-by: Shikhar Bhatt <shikhar.bhatt011@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
VC API 2024-H2
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrhender