remove obsolete issuer name from sd-jwt record

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
openwallet-foundation-labs · Aug 15, 2024 · f8bc917 · f8bc917
1 parent ae51469
commit f8bc917
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 23 deletions.
diff --git a/src/WalletFramework.Oid4Vc/Oid4Vci/Implementations/SdJwtRecordExtensions.cs b/src/WalletFramework.Oid4Vc/Oid4Vci/Implementations/SdJwtRecordExtensions.cs
@@ -60,19 +60,11 @@ public static SdJwtRecord ToRecord(
                 };
             })
             .ToList();
-
-        var issuerName = issuerMetadata
-            .Display
-            .ToNullable()?
-            .ToDictionary(
-                 issuerDisplay => issuerDisplay.Locale.ToNullable()?.ToString(),
-                 issuerDisplay => issuerDisplay.Name.ToNullable()?.ToString());
 
         var record = new SdJwtRecord(
             sdJwtDoc,
             claims!,
             display!,
-            issuerName!,
             keyId);
 
         return record;

diff --git a/src/WalletFramework.SdJwtVc/Models/Records/SdJwtRecord.cs b/src/WalletFramework.SdJwtVc/Models/Records/SdJwtRecord.cs
@@ -33,11 +33,6 @@ public sealed class SdJwtRecord : RecordBase, ICredential
     /// </summary>
     public Dictionary<string, string> Claims { get; set; }
 
-    /// <summary>
-    ///     Gets or sets the name of the issuer in different languages.
-    /// </summary>
-    public Dictionary<string, string>? IssuerName { get; set; }
-
     /// <summary>
     ///     Gets the disclosures.
     /// </summary>
@@ -110,7 +105,6 @@ public SdJwtRecord()
     /// </summary>
     /// <param name="displayedAttributes">The attributes that should be displayed.</param>
     /// <param name="claims">The claims made.</param>
-    /// <param name="issuerName">The name of the issuer in different languages.</param>
     /// <param name="disclosures">The disclosures.</param>
     /// <param name="display">The display of the credential.</param>
     /// <param name="issuerId"></param>
@@ -119,7 +113,6 @@ public SdJwtRecord()
     public SdJwtRecord(
         Dictionary<string, ClaimMetadata> displayedAttributes,
         Dictionary<string, string> claims,
-        Dictionary<string, string> issuerName,
         ImmutableArray<string> disclosures,
         List<SdJwtDisplay> display,
         string issuerId,
@@ -132,8 +125,6 @@ public SdJwtRecord(
         DisplayedAttributes = displayedAttributes;
 
         EncodedIssuerSignedJwt = encodedIssuerSignedJwt;
-
-        IssuerName = issuerName;
 
         IssuerId = issuerId;
     }
@@ -142,7 +133,6 @@ public SdJwtRecord(
         string serializedSdJwtWithDisclosures,
         Dictionary<string, ClaimMetadata> displayedAttributes,
         List<SdJwtDisplay> display,
-        Dictionary<string, string> issuerName,
         KeyId keyId)
     {
         Id = Guid.NewGuid().ToString();
@@ -154,8 +144,6 @@ public SdJwtRecord(
         Display = display;
         DisplayedAttributes = displayedAttributes;
 
-        IssuerName = issuerName;
-
         KeyId = keyId;
         IssuerId = sdJwtDoc.UnsecuredPayload.SelectToken("iss")?.Value<string>() 
                    ?? throw new ArgumentNullException(nameof(IssuerId), "iss claim is missing or null");
@@ -167,7 +155,6 @@ public SdJwtRecord(
         SdJwtDoc sdJwtDoc,
         Dictionary<string, ClaimMetadata> displayedAttributes,
         List<SdJwtDisplay> display,
-        Dictionary<string, string> issuerName,
         KeyId keyId)
     {
         Id = Guid.NewGuid().ToString();
@@ -178,8 +165,6 @@ public SdJwtRecord(
         Display = display;
         DisplayedAttributes = displayedAttributes;
 
-        IssuerName = issuerName;
-
         KeyId = keyId;
         IssuerId = sdJwtDoc.UnsecuredPayload.SelectToken("iss")?.Value<string>() 
                    ?? throw new ArgumentNullException(nameof(IssuerId), "iss claim is missing or null");