-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add status list support #235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
kenkosmowski
requested changes
Dec 6, 2024
None: () => Option<CredentialState>.None); | ||
} | ||
|
||
private static byte[] DecompressWithZlib(byte[] compressedData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the SharpZipLib library is last updated on January 2023 we could also work with an pure C# implementation like this:
if (compressedData == null || compressedData.Length == 0)
throw new ArgumentException("Compressed data cannot be null or empty");
// Check the zlib header (2 bytes)
if (compressedData.Length < 6)
throw new InvalidDataException("Compressed data is too short.");
byte cmf = compressedData[0];
byte flg = compressedData[1];
// Validate compression method (CM) and compression info (CINFO)
if ((cmf & 0x0F) != 8 || (cmf >> 4) > 7)
throw new InvalidDataException("Unsupported zlib compression method or info.");
// Validate the header checksum
if ((cmf * 256 + flg) % 31 != 0)
throw new InvalidDataException("Invalid zlib header checksum.");
// Remove the zlib header (first 2 bytes) and Adler-32 checksum (last 4 bytes)
int deflateDataLength = compressedData.Length - 6;
if (deflateDataLength <= 0)
throw new InvalidDataException("No deflate-compressed data found.");
byte[] deflateData = new byte[deflateDataLength];
Array.Copy(compressedData, 2, deflateData, 0, deflateDataLength);
// Decompress using DeflateStream
using (var inputStream = new MemoryStream(deflateData))
using (var deflateStream = new DeflateStream(inputStream, CompressionMode.Decompress))
using (var outputStream = new MemoryStream())
{
deflateStream.CopyTo(outputStream);
return outputStream.ToArray();
}
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
kenkosmowski
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves: