Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add status list support #235

Merged
merged 6 commits into from
Dec 9, 2024
Merged

add status list support #235

merged 6 commits into from
Dec 9, 2024

Conversation

JoTiTu
Copy link
Contributor

@JoTiTu JoTiTu commented Dec 3, 2024

Short description of what this resolves:

  • This PR adds the status list to SD-JWT credentials

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
@JoTiTu JoTiTu requested a review from kenkosmowski December 3, 2024 12:26
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
None: () => Option<CredentialState>.None);
}

private static byte[] DecompressWithZlib(byte[] compressedData)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the SharpZipLib library is last updated on January 2023 we could also work with an pure C# implementation like this:

if (compressedData == null || compressedData.Length == 0)
            throw new ArgumentException("Compressed data cannot be null or empty");

        // Check the zlib header (2 bytes)
        if (compressedData.Length < 6)
            throw new InvalidDataException("Compressed data is too short.");

        byte cmf = compressedData[0];
        byte flg = compressedData[1];

        // Validate compression method (CM) and compression info (CINFO)
        if ((cmf & 0x0F) != 8 || (cmf >> 4) > 7)
            throw new InvalidDataException("Unsupported zlib compression method or info.");

        // Validate the header checksum
        if ((cmf * 256 + flg) % 31 != 0)
            throw new InvalidDataException("Invalid zlib header checksum.");

        // Remove the zlib header (first 2 bytes) and Adler-32 checksum (last 4 bytes)
        int deflateDataLength = compressedData.Length - 6;
        if (deflateDataLength <= 0)
            throw new InvalidDataException("No deflate-compressed data found.");

        byte[] deflateData = new byte[deflateDataLength];
        Array.Copy(compressedData, 2, deflateData, 0, deflateDataLength);

        // Decompress using DeflateStream
        using (var inputStream = new MemoryStream(deflateData))
        using (var deflateStream = new DeflateStream(inputStream, CompressionMode.Decompress))
        using (var outputStream = new MemoryStream())
        {
            deflateStream.CopyTo(outputStream);
            return outputStream.ToArray();
        }

Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
@JoTiTu JoTiTu requested a review from kenkosmowski December 9, 2024 10:11
Signed-off-by: Johannes Tuerk <johannes.tuerk@lissi.id>
@JoTiTu JoTiTu merged commit f23104f into main Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants