Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query connections by theirLabel and alias #1819

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Apr 4, 2024

This was mainly created to fix openwallet-foundation/credo-ts-ext#267, as it might be useful to query connections by these parameters.

The bad thing about it is that previously created connections won't work with these query parameters, unless we do a migration script (which of course should be reserved to a major version).

Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@GHkrishna
Copy link
Contributor

GHkrishna commented Jun 20, 2024

Any specific reason why we have not merged this?

Will this be blocked until the next major release

Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: f0ae21a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra
Copy link
Contributor

TimoGlastra commented Jun 21, 2024

The reason we didn't merge it, as adding it doesn't solve it for already stored records. We can probably merge it now, and do the migration later on? However, it won't be clear from the API that these values are only queryable for new records. So maybe wait until 0.6?

@GHkrishna
Copy link
Contributor

Okay, that seems a bit far but makes sense to add it in 0.6 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rest] DIDComm connection query parameters
3 participants