Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geppetto instances getGeometryType #317

Open
ddelpiano opened this issue Jun 29, 2020 · 2 comments
Open

Geppetto instances getGeometryType #317

ddelpiano opened this issue Jun 29, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ddelpiano
Copy link
Contributor

ddelpiano commented Jun 29, 2020

on the same line of the setGeometryType made available from the SceneController, we should have a getter method that allow us to get the geometry type (lines, cylinders, etc) for a specific instance.

@tarelli my understanding at the moment is that this is possible only going through the rendered scene in the 3dengine and once we found the instance check the geometry used. I thought of storing the geometryType for a specific instance when this is added based on the canvas parameters to render new instances and store this in the instance, and once the setter method gets called store the change in the instances itself to make the getter lighter. Any cons in this that you might think about? Thx.

@ddelpiano ddelpiano self-assigned this Jun 29, 2020
@ddelpiano ddelpiano added the enhancement New feature or request label Jun 29, 2020
@tarelli
Copy link
Member

tarelli commented Jun 30, 2020

@ddelpiano yes there is no such a getter but also, we are rewriting the canvas :) how urgent is this?

@ddelpiano
Copy link
Contributor Author

not urgent at all, we discussed this in yesterday's sprint call and we decided to keep track of this, at the moment we have a workaround within vfb but it would be better to replace that with such getter whenever this will be available. Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants