Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all references to node_modules/geppetto-client #325

Open
filippomc opened this issue Jul 21, 2020 · 0 comments
Open

Remove all references to node_modules/geppetto-client #325

filippomc opened this issue Jul 21, 2020 · 0 comments
Labels
refactoring

Comments

@filippomc
Copy link
Contributor

filippomc commented Jul 21, 2020 •
edited
Loading

Some functionalities rely on absolute reference to files inside the node_modules folder.
The references are coming from places like:

  • pages loading css
  • command controller help
  • extract commands -> GEPPETTO.Utility.extractCommandsFromFile(
  • workers new Worker("/geppetto/node_modules/@geppettoengine/geppetto-client/geppetto-client/js/geppettoProject/PullStatusWorker.js");

It is important to remove those references in order to make the application code deployable without the node_modules folder in place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filippomc