Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query Component's Image Carousel Feature #338

Open
jrmartin opened this issue Sep 22, 2020 · 0 comments · Fixed by #339
Open

Fix Query Component's Image Carousel Feature #338

jrmartin opened this issue Sep 22, 2020 · 0 comments · Fixed by #339
Assignees
Labels
bug Something isn't working

Comments

@jrmartin
Copy link
Contributor

There's a bug when creating a carousel inside the Query component.

This solution fixes it kenwheeler/slick#1953 (comment)

stacktrace:

  | Slick.initADA | @ | slick.js:1306
-- | -- | -- | --
  | Slick.init | @ | slick.js:1287
  | Slick | @ | slick.js:182
  | $.fn.slick | @ | slick.js:3002
  | componentDidMount | @ | slideshowImageComponent.js:165
  | commitLifeCycles | @ | react-dom.development.js:19814
  | commitLayoutEffects | @ | react-dom.development.js:22803
  | callCallback | @ | react-dom.development.js:188
  | invokeGuardedCallbackDev | @ | react-dom.development.js:237
  | invokeGuardedCallback | @ | react-dom.development.js:292
  | commitRootImpl | @ | react-dom.development.js:22541
  | unstable_runWithPriority | @ | scheduler.development.js:653
  | runWithPriority$1 | @ | react-dom.development.js:11039
  | commitRoot | @ | react-dom.development.js:22381
  | finishSyncRender | @ | react-dom.development.js:21807
  | performSyncWorkOnRoot | @ | react-dom.development.js:21793
  | (anonymous) | @ | react-dom.development.js:11089
  | unstable_runWithPriority | @ | scheduler.development.js:653
  | runWithPriority$1 | @ | react-dom.development.js:11039
  | flushSyncCallbackQueueImpl | @ | react-dom.development.js:11084
  | flushSyncCallbackQueue | @ | react-dom.development.js:11072
  | scheduleUpdateOnFiber | @ | react-dom.development.js:21199
  | enqueueSetState | @ | react-dom.development.js:12639
  | Component.setState | @ | react.development.js:471
  | switchView | @ | queryBuilder.js:328
  | queryDoneCallback | @ | queryBuilder.js:939
  | (anonymous) | @ | QueriesController.js:37
  | parseAndNotify | @ | MessageSocket.js:310
  | processBinaryMessage | @ | MessageSocket.js:327
  | GEPPETTO.MessageSocket.socket.onmessage | @ | MessageSocket.js:106

  overrideMethod @ react_devtools_backend.js:2273
  console.error @ VFBMainContainer.js_+_105_modules:73942
  logCapturedError @ react-dom.development.js:19527
  logError @ react-dom.development.js:19564
  callback @ react-dom.development.js:20744
  callCallback @ react-dom.development.js:12490
  commitUpdateQueue @ react-dom.development.js:12511
  commitLifeCycles @ react-dom.development.js:19858
  commitLayoutEffects @ react-dom.development.js:22803
  callCallback @ react-dom.development.js:188
  invokeGuardedCallbackDev @ react-dom.development.js:237
  invokeGuardedCallback @ react-dom.development.js:292
  commitRootImpl @ react-dom.development.js:22541
  unstable_runWithPriority @ scheduler.development.js:653
  runWithPriority$1 @ react-dom.development.js:11039
  commitRoot @ react-dom.development.js:22381
  finishSyncRender @ react-dom.development.js:21807
  performSyncWorkOnRoot @ react-dom.development.js:21793
  (anonymous) @ react-dom.development.js:11089
  unstable_runWithPriority @ scheduler.development.js:653
  runWithPriority$1 @ react-dom.development.js:11039
  flushSyncCallbackQueueImpl @ react-dom.development.js:11084
  flushSyncCallbackQueue @ react-dom.development.js:11072
  scheduleUpdateOnFiber @ react-dom.development.js:21199
  enqueueSetState @ react-dom.development.js:12639
  Component.setState @ react.development.js:471
  switchView @ queryBuilder.js:328
  queryDoneCallback @ queryBuilder.js:939
  (anonymous) @ QueriesController.js:37
  parseAndNotify @ MessageSocket.js:310
  Show 2 more frames
@jrmartin jrmartin self-assigned this Sep 22, 2020
@jrmartin jrmartin added the bug Something isn't working label Sep 22, 2020
@filippomc filippomc linked a pull request Sep 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant