Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version update bundles use old cached version #345

Open
filippomc opened this issue Dec 16, 2020 · 0 comments
Open

Version update bundles use old cached version #345

filippomc opened this issue Dec 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@filippomc
Copy link
Contributor

The main bundles are referenced statically in the main entry page:

geppetto-client/geppetto-client/js/pages/geppetto/geppetto.ejs

Line 187 in 8ac5d63

<script

There is no way to change the name to force a cache clear instead.

Proposal: add the commit hash as a parameter at build time:

<%= cssPaths%>geppetto/build/common.bundle.js becomes <%= cssPaths%>geppetto/build/common.bundle.js?v=<%= version%>
@filippomc filippomc added the enhancement New feature or request label Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filippomc