Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geppetto-UI showcase folders should be excluded from release/production version #349

Open
afonsobspinto opened this issue Feb 18, 2021 · 0 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@afonsobspinto
Copy link
Member

afonsobspinto commented Feb 18, 2021

In my opinion, geppetto-ui showcase folders should not be included in the release/production version of geppetto-client.

I support my suggestion with an extreme case which is the canvas showcase, where model.json increases the bundle size in 100 mb (still under evaluation here).

How to handle this?
for manual installations: Change the instructions to exclude showcase examples (maybe with a script?). But keep it optional.
for npm releases: We can use .npmignore

@afonsobspinto afonsobspinto added enhancement New feature or request question Further information is requested labels Feb 18, 2021
@afonsobspinto afonsobspinto changed the title Geppetto-UI showcase folders should be excluded from release version Geppetto-UI showcase folders should be excluded from release/production version Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant