Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/361 #362

Merged
merged 3 commits into from
May 31, 2021
Merged

Feature/361 #362

merged 3 commits into from
May 31, 2021

Conversation

filippomc
Copy link
Contributor

@filippomc filippomc commented May 11, 2021 •
edited
Loading

  • Add coverage for whatever new functionality, to a JUnit test if it's backend, to a Casper Test if it's frontend
  • Make sure both push and pr travis builds are passing before asking for a review

Closes #361

@filippomc filippomc linked an issue May 11, 2021 that may be closed by this pull request
Simple instances are not updated on geppetto model merge #361
Open
@filippomc filippomc self-assigned this May 11, 2021
@filippomc filippomc requested a review from lrebscher May 11, 2021 16:48
lrebscher
lrebscher approved these changes May 11, 2021
View reviewed changes
Copy link

@lrebscher lrebscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarelli tarelli merged commit ced2742 into development May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrebscher lrebscher lrebscher approved these changes

Assignees

@filippomc filippomc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple instances are not updated on geppetto model merge
3 participants
@filippomc @lrebscher @tarelli