Merge query results on refined query when sub-results contains different headers #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippomc
requested changes
Sep 2, 2020
| // Add headers for new result to 'finalResults' list, this is done after merging results | ||
| // to avoid having a mismatch of values and headers prior to the merge. | ||
| if(!first){ | ||
| finalResults.getHeader().addAll(result.getHeader()); |
There was a problem hiding this comment.
This is really calling a unit test! We have this in pygeppetto: https://github.com/openworm/pygeppetto/blob/5932729e4098cd6e0f766b9fd43ff6b33fce56a2/tests/test_datasource_service.py#L33. Should test also the case with different headers from here VirtualFlyBrain/geppetto-vfb#464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of issue VirtualFlyBrain/geppetto-vfb#464
Outcome of query search:
NBLAST Similar to VGlut-F-200114 with List all images included in FlyCircuit 1.0 - single neurons (Chiang2010)