Skip to content

Commit

Permalink
feat(ci): use different check names for different test groups
Browse files Browse the repository at this point in the history
This way the different tests won't override each other and it will be easier to
spot failing tests.
Currently this can only be done by manually inspecting the logs
  • Loading branch information
vringar committed Dec 24, 2023
1 parent b79a7fa commit c5f4ba8
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,6 @@ jobs:
uses: dorny/test-reporter@v1
if: success() || failure() # run this step even if previous step failed
with:
name: OpenWPM # Name of the check run which will be created
path: junit-report.xml # Path to test results
name: ${{matrix.test-groups}} # Name of the check run which will be created
path: ${{matrix.test-groups}}-report.xml # Path to test results
reporter: java-junit # Format of test results
2 changes: 1 addition & 1 deletion scripts/ci.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

python -m pytest --cov=openwpm --junit-xml=junit-report.xml --cov-report=xml $TESTS -s -v --durations=10;
python -m pytest --cov=openwpm --junit-xml="$TESTS"-report.xml --cov-report=xml $TESTS -s -v --durations=10;
exit_code=$?;
if [[ "$exit_code" -ne 0 ]]; then
exit $exit_code;
Expand Down
4 changes: 2 additions & 2 deletions test/test_extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,10 @@
DOCUMENT_COOKIE_READ = (
JS_COOKIE_TEST_URL,
"8",
"9",
"21",
"set_cookie",
"",
"set_cookie@" + JS_COOKIE_TEST_URL + ":8:9"
"set_cookie@" + JS_COOKIE_TEST_URL + ":8:21"
"\nonload@" + JS_COOKIE_TEST_URL + ":1:1",
"window.document.cookie",
"get",
Expand Down

0 comments on commit c5f4ba8

Please sign in to comment.