From c5f4ba8ac0c49f43984f0cb58e5a0fa62c9270e5 Mon Sep 17 00:00:00 2001 From: vringar Date: Sun, 24 Dec 2023 12:31:12 +0100 Subject: [PATCH] feat(ci): use different check names for different test groups This way the different tests won't override each other and it will be easier to spot failing tests. Currently this can only be done by manually inspecting the logs --- .github/workflows/run-tests.yaml | 4 ++-- scripts/ci.sh | 2 +- test/test_extension.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-tests.yaml b/.github/workflows/run-tests.yaml index ac4bb4793..34485228c 100644 --- a/.github/workflows/run-tests.yaml +++ b/.github/workflows/run-tests.yaml @@ -144,6 +144,6 @@ jobs: uses: dorny/test-reporter@v1 if: success() || failure() # run this step even if previous step failed with: - name: OpenWPM # Name of the check run which will be created - path: junit-report.xml # Path to test results + name: ${{matrix.test-groups}} # Name of the check run which will be created + path: ${{matrix.test-groups}}-report.xml # Path to test results reporter: java-junit # Format of test results diff --git a/scripts/ci.sh b/scripts/ci.sh index 75f569301..f96ac9c6c 100755 --- a/scripts/ci.sh +++ b/scripts/ci.sh @@ -1,6 +1,6 @@ #!/bin/bash -python -m pytest --cov=openwpm --junit-xml=junit-report.xml --cov-report=xml $TESTS -s -v --durations=10; +python -m pytest --cov=openwpm --junit-xml="$TESTS"-report.xml --cov-report=xml $TESTS -s -v --durations=10; exit_code=$?; if [[ "$exit_code" -ne 0 ]]; then exit $exit_code; diff --git a/test/test_extension.py b/test/test_extension.py index 5191f50aa..1fe4e5b9f 100644 --- a/test/test_extension.py +++ b/test/test_extension.py @@ -231,10 +231,10 @@ DOCUMENT_COOKIE_READ = ( JS_COOKIE_TEST_URL, "8", - "9", + "21", "set_cookie", "", - "set_cookie@" + JS_COOKIE_TEST_URL + ":8:9" + "set_cookie@" + JS_COOKIE_TEST_URL + ":8:21" "\nonload@" + JS_COOKIE_TEST_URL + ":1:1", "window.document.cookie", "get",