Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Firefox 134 and migrate back to conda #1109

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Update to Firefox 134 and migrate back to conda #1109

merged 8 commits into from
Jan 16, 2025

Conversation

englehardt
Copy link
Collaborator

@englehardt englehardt commented Jan 16, 2025

As mentioned in #1105, mamba has been merged upstream into conda. Looks like as of 2025 they've fully deprecated it and stopped building the mamba binaries.

I replaced all references to mamba with conda and things "just work" both locally and on the CI tests, so I think we're all good.

@englehardt englehardt changed the title Update to Firefox 134 Update to Firefox 134 and migrate back to mamba Jan 16, 2025
@englehardt englehardt requested a review from vringar January 16, 2025 03:26
@englehardt englehardt changed the title Update to Firefox 134 and migrate back to mamba Update to Firefox 134 and migrate back to conda Jan 16, 2025
…conda env

The --force flag was deprecated and replaces by --yes which is currently undocumented
conda/conda#13704

This fix makes use of the new functionality
Copy link
Contributor

@vringar vringar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added back the ability to rerun our conda modifying scripts (repin and install) without having to first delete the openwpm environment
Everything else looks great

@vringar vringar enabled auto-merge (rebase) January 16, 2025 17:16
@vringar vringar merged commit d23fc19 into master Jan 16, 2025
19 checks passed
@vringar vringar deleted the firefox-134 branch January 16, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants