Skip to content

Release

Release #958

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / OpenWPM failed Oct 21, 2023 in 0s

OpenWPM ❌

Tests failed

❌ junit-report.xml

39 tests were completed in 501s with 36 passed, 3 failed and 0 skipped.

Test suite Passed Failed Skipped Time
pytest 36✅ 3❌ 501s

❌ pytest

test.test_js_instrument.TestJSInstrumentNonExistingWindowProperty
  ✅ test_instrument_object
test.test_js_instrument.TestJSInstrumentExistingWindowProperty
  ✅ test_instrument_object
test.test_js_instrument.TestJSInstrumentByPython
  ✅ test_instrument_object
test.test_js_instrument.TestJSInstrumentMockWindowProperty
  ✅ test_instrument_object
test.test_js_instrument.TestJSInstrument
  ✅ test_instrument_object
test.test_js_instrument.TestJSInstrumentRecursiveProperties
  ✅ test_instrument_object
test.test_js_instrument_py
  ✅ test_validate_good
  ✅ test_validate_bad__log_settings_missing
  ✅ test_validate_bad__log_settings_invalid
  ✅ test_validate_bad__not_a_list
  ✅ test_validate_bad__missing_object
  ✅ test_validated_bad__missing_instrumentedName
  ✅ test_merge_and_validate_multiple_overlap_properties_to_instrument_properties_to_exclude
  ✅ test_merge_and_validate_multiple_overlap_properties
  ✅ test_merge_when_log_settings_is_null
  ✅ test_merge_diff_instrumented_names
  ✅ test_merge_multiple_duped_properties
  ✅ test_merge_multiple_duped_properties_different_log_settings
  ✅ test_api_whole_module
  ✅ test_api_two_keys_in_shortcut
  ✅ test_api_instances_on_window
  ✅ test_api_instances_on_window_with_properties
  ✅ test_api_module_specific_properties
  ✅ test_api_passing_partial_log_settings
  ✅ test_api_collection_fingerprinting
  ✅ test_complete_pass
test.test_mp_logger
  ✅ test_multiprocess
  ✅ test_multiple_instances
  ✅ test_child_process_with_exception
  ✅ test_child_process_logging
test.test_task_manager
  ✅ test_failure_limit_value
  ✅ test_failure_limit_exceeded
  ✅ test_failure_limit_reset
  ❌ test_assertion_error_propagation[False-expectation0]
	task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18e5c4a0>
  ❌ test_assertion_error_propagation[True-expectation1]
	task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18d55580>
test.test_timer
  ✅ test_command_duration
test.test_webdriver_utils
  ✅ test_parse_neterror
  ✅ test_parse_neterror_integration
test.test_xvfb_browser
  ❌ test_display_shutdown
	task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18ea9080>

Annotations

Check failure on line 0 in junit-report.xml

See this annotation in the file changed.

@github-actions github-actions / OpenWPM

pytest ► test.test_task_manager ► test_assertion_error_propagation[False-expectation0]

Failed test found in:
  junit-report.xml
Error:
  task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18e5c4a0>
Raw output
task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18e5c4a0>
default_params = (ManagerParams(data_directory=PosixPath('/tmp/pytest-of-runner/pytest-0/test_assertion_error_propagati0'), log_path=Po...'/tmp'), maximum_profile_size=None, recovery_tar=None, donottrack=False, tracking_protection=False, custom_params={})])
testing = False, expectation = <contextlib.nullcontext object at 0x7f9f1906e6c0>

    @pytest.mark.parametrize(
        "testing,expectation",
        [
            (False, does_not_raise()),
            (True, pytest.raises(AssertionError, match="From inside the command")),
        ],
    )
    def test_assertion_error_propagation(
        task_manager_creator, default_params, testing, expectation
    ):
        """Test that assertion errors bubble up through the TaskManager when running tests"""
        manager_params, browser_params = default_params
        manager_params.num_browsers = 1
        manager_params.testing = testing
        manager, _ = task_manager_creator((manager_params, browser_params[:1]))
        cs = CommandSequence("http://example.com", blocking=True)
        cs.append_command(CrashingAssertionCommand())
        with expectation:
>           with manager:

/home/runner/work/OpenWPM/OpenWPM/test/test_task_manager.py:82: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:179: in __exit__
    self.close()
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:505: in close
    self._shutdown_manager(relaxed=relaxed)
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:326: in _shutdown_manager
    browser.shutdown_browser(during_init, force=not relaxed)
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:610: in shutdown_browser
    self.close_browser_manager(force=force)
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:341: in close_browser_manager
    self.kill_browser_manager()
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:550: in kill_browser_manager
    self.logger.debug(
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1527: in debug
    self._log(DEBUG, msg, args, **kwargs)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1684: in _log
    self.handle(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1700: in handle
    self.callHandlers(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1762: in callHandlers
    hdlr.handle(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1028: in handle
    self.emit(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/site-packages/_pytest/logging.py:372: in emit
    super().emit(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1168: in emit
    self.handleError(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1160: in emit
    msg = self.format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:999: in format
    return fmt.format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/site-packages/_pytest/logging.py:136: in format
    return super().format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:703: in format
    record.message = record.getMessage()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <LogRecord: openwpm, 10, /home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py, 550, "BROWSER %i: Attempting to kill BrowserManager with pid %i. Browser PID: %s">

    def getMessage(self):
        """
        Return the message for this LogRecord.
    
        Return the message for this LogRecord after merging any user-supplied
        arguments with the message.
        """
        msg = str(self.msg)
        if self.args:
>           msg = msg % self.args
E           TypeError: %i format: a real number is required, not tuple

/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:392: TypeError

Check failure on line 0 in junit-report.xml

See this annotation in the file changed.

@github-actions github-actions / OpenWPM

pytest ► test.test_task_manager ► test_assertion_error_propagation[True-expectation1]

Failed test found in:
  junit-report.xml
Error:
  task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18d55580>
Raw output
task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18d55580>
default_params = (ManagerParams(data_directory=PosixPath('/tmp/pytest-of-runner/pytest-0/test_assertion_error_propagati1'), log_path=Po...'/tmp'), maximum_profile_size=None, recovery_tar=None, donottrack=False, tracking_protection=False, custom_params={})])
testing = True
expectation = <_pytest.python_api.RaisesContext object at 0x7f9f1906ffb0>

    @pytest.mark.parametrize(
        "testing,expectation",
        [
            (False, does_not_raise()),
            (True, pytest.raises(AssertionError, match="From inside the command")),
        ],
    )
    def test_assertion_error_propagation(
        task_manager_creator, default_params, testing, expectation
    ):
        """Test that assertion errors bubble up through the TaskManager when running tests"""
        manager_params, browser_params = default_params
        manager_params.num_browsers = 1
        manager_params.testing = testing
        manager, _ = task_manager_creator((manager_params, browser_params[:1]))
        cs = CommandSequence("http://example.com", blocking=True)
        cs.append_command(CrashingAssertionCommand())
        with expectation:
            with manager:
>               manager.execute_command_sequence(cs)

/home/runner/work/OpenWPM/OpenWPM/test/test_task_manager.py:83: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:461: in execute_command_sequence
    self._check_failure_status()
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:347: in _check_failure_status
    self._shutdown_manager()
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:326: in _shutdown_manager
    browser.shutdown_browser(during_init, force=not relaxed)
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:610: in shutdown_browser
    self.close_browser_manager(force=force)
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:341: in close_browser_manager
    self.kill_browser_manager()
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:550: in kill_browser_manager
    self.logger.debug(
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1527: in debug
    self._log(DEBUG, msg, args, **kwargs)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1684: in _log
    self.handle(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1700: in handle
    self.callHandlers(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1762: in callHandlers
    hdlr.handle(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1028: in handle
    self.emit(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/site-packages/_pytest/logging.py:372: in emit
    super().emit(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1168: in emit
    self.handleError(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1160: in emit
    msg = self.format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:999: in format
    return fmt.format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/site-packages/_pytest/logging.py:136: in format
    return super().format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:703: in format
    record.message = record.getMessage()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <LogRecord: openwpm, 10, /home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py, 550, "BROWSER %i: Attempting to kill BrowserManager with pid %i. Browser PID: %s">

    def getMessage(self):
        """
        Return the message for this LogRecord.
    
        Return the message for this LogRecord after merging any user-supplied
        arguments with the message.
        """
        msg = str(self.msg)
        if self.args:
>           msg = msg % self.args
E           TypeError: %i format: a real number is required, not tuple

/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:392: TypeError

Check failure on line 0 in junit-report.xml

See this annotation in the file changed.

@github-actions github-actions / OpenWPM

pytest ► test.test_xvfb_browser ► test_display_shutdown

Failed test found in:
  junit-report.xml
Error:
  task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18ea9080>
Raw output
task_manager_creator = <function task_manager_creator.<locals>._create_task_manager at 0x7f9f18ea9080>
default_params = (ManagerParams(data_directory=PosixPath('/tmp/pytest-of-runner/pytest-0/test_display_shutdown0'), log_path=PosixPath('...'/tmp'), maximum_profile_size=None, recovery_tar=None, donottrack=False, tracking_protection=False, custom_params={})])

    def test_display_shutdown(task_manager_creator, default_params):
        """Test the XVFB display option to see if it runs and deletes the lockfile upon shutdown"""
        manager_params, browser_params = default_params
        for browser_param in browser_params:
            browser_param.display_mode = "xvfb"
        TEST_SITE = BASE_TEST_URL + "/test_pages/simple_a.html"
        manager, db = task_manager_creator((manager_params, browser_params))
        port = manager.browsers[0].display_port
    
        sequence = CommandSequence(TEST_SITE)
        sequence.get()
        sequence.append_command(ExceptionCommand())
        manager.execute_command_sequence(sequence)
>       manager.close()

/home/runner/work/OpenWPM/OpenWPM/test/test_xvfb_browser.py:37: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:505: in close
    self._shutdown_manager(relaxed=relaxed)
/home/runner/work/OpenWPM/OpenWPM/openwpm/task_manager.py:326: in _shutdown_manager
    browser.shutdown_browser(during_init, force=not relaxed)
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:610: in shutdown_browser
    self.close_browser_manager(force=force)
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:341: in close_browser_manager
    self.kill_browser_manager()
/home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py:550: in kill_browser_manager
    self.logger.debug(
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1527: in debug
    self._log(DEBUG, msg, args, **kwargs)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1684: in _log
    self.handle(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1700: in handle
    self.callHandlers(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1762: in callHandlers
    hdlr.handle(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1028: in handle
    self.emit(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/site-packages/_pytest/logging.py:372: in emit
    super().emit(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1168: in emit
    self.handleError(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:1160: in emit
    msg = self.format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:999: in format
    return fmt.format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/site-packages/_pytest/logging.py:136: in format
    return super().format(record)
/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:703: in format
    record.message = record.getMessage()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <LogRecord: openwpm, 10, /home/runner/work/OpenWPM/OpenWPM/openwpm/browser_manager.py, 550, "BROWSER %i: Attempting to kill BrowserManager with pid %i. Browser PID: %s">

    def getMessage(self):
        """
        Return the message for this LogRecord.
    
        Return the message for this LogRecord after merging any user-supplied
        arguments with the message.
        """
        msg = str(self.msg)
        if self.args:
>           msg = msg % self.args
E           TypeError: %i format: a real number is required, not tuple

/home/runner/mamba/envs/openwpm/lib/python3.12/logging/__init__.py:392: TypeError