-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various stability enhancements #20
Conversation
Overall this looks good to me. I merged #18 so we will need to rebase this before merging. I'm going to run a test crawl shortly with the new logging (openwpm/OpenWPM#434). I'll r+ if I don't find any issues during that. |
…ployed redis instance
…ling due to sporadic worker crashes
Thanks! This PR is now rebased on current master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through a bunch of test runs today with this. Thanks for the improvements!
One question: now that we've moved redis off of a preemptible node, do we still have the option to run crawls with preemptible nodes? I suspect the remaining concern is data loss from visits cached in the S3Aggregator.
You are right, we can't yet reliably run crawls with preemtible nodes. I filed a tracking issue here: #21 |
Fixes #19
Note: Includes the changes from #18 currently. If #18 is merged first, this PR will be rebased on the latest master