Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various stability enhancements #20

Merged
merged 10 commits into from
Aug 2, 2019
Merged

Various stability enhancements #20

merged 10 commits into from
Aug 2, 2019

Conversation

motin
Copy link
Contributor

@motin motin commented Aug 1, 2019

Fixes #19

Note: Includes the changes from #18 currently. If #18 is merged first, this PR will be rebased on the latest master

@englehardt
Copy link
Contributor

Overall this looks good to me. I merged #18 so we will need to rebase this before merging. I'm going to run a test crawl shortly with the new logging (openwpm/OpenWPM#434). I'll r+ if I don't find any issues during that.

@motin
Copy link
Contributor Author

motin commented Aug 2, 2019

I merged #18 so we will need to rebase this before merging

Thanks! This PR is now rebased on current master.

Copy link
Contributor

@englehardt englehardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through a bunch of test runs today with this. Thanks for the improvements!

One question: now that we've moved redis off of a preemptible node, do we still have the option to run crawls with preemptible nodes? I suspect the remaining concern is data loss from visits cached in the S3Aggregator.

@motin
Copy link
Contributor Author

motin commented Aug 2, 2019

One question: now that we've moved redis off of a preemptible node, do we still have the option to run crawls with preemptible nodes? I suspect the remaining concern is data loss from visits cached in the S3Aggregator.

You are right, we can't yet reliably run crawls with preemtible nodes. I filed a tracking issue here: #21

@motin motin merged commit 741c5e7 into master Aug 2, 2019
@englehardt englehardt deleted the issue-19 branch August 17, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Redis service needs to be persistent / resilient in GCP
2 participants