Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: enable release snapshots in selector #58

Closed
efahl opened this issue Nov 28, 2024 · 14 comments
Closed

config: enable release snapshots in selector #58

efahl opened this issue Nov 28, 2024 · 14 comments

Comments

@efahl
Copy link
Contributor

efahl commented Nov 28, 2024

@mwarning @aparcar

What do you think about toggling on the release-SNAPSHOT builds in FS? They are already available in auc and owut by default, seems like it's just a roadblock for people who want to use FS to do the same job.

https://github.com/openwrt/firmware-selector-openwrt-org/blob/master/www/config.js#L17

@aparcar
Copy link
Member

aparcar commented Nov 28, 2024

It's hidden so no regular user breaks the system thinking it's fine to install something unreleased.

Feel free to use the GitHub page here with snapshots enabled, however it does not show 24.10 since it not in the .versions.json file.

https://openwrt.github.io/firmware-selector-openwrt-org/

@KA2107
Copy link

KA2107 commented Nov 28, 2024

Related #7

@efahl
Copy link
Contributor Author

efahl commented Nov 28, 2024

Oh, yeah, I forgot about that one.

@efahl
Copy link
Contributor Author

efahl commented Nov 28, 2024

Ok, so how about adding them as Danger-24.10-SNAPSHOT and so on as their labels, then sort the list so they are at the bottom. Also add a comment about "Release SNAPSHOT builds are potentially dangerous, use at your own risk". That seems like it would be good enough to instill some hesitation into people so they do their homework before blindly installing them.

@KA2107
Copy link

KA2107 commented Nov 28, 2024

Feel free to use the GitHub page here with snapshots enabled, however it does not show 24.10 since it not in the .versions.json file.

https://openwrt.github.io/firmware-selector-openwrt-org/

Mentioned this in #7 (comment)

@KA2107
Copy link

KA2107 commented Nov 28, 2024

Ok, so how about adding them as Danger-24.10-SNAPSHOT and so on as their labels, then sort the list so they are at the bottom. Also add a comment about "Release SNAPSHOT builds are potentially dangerous, use at your own risk".

Same should be done for MAIN SNAPSHOT in my opinion, as that is even more dangerous to use compared to RELEASE SNAPSHOTs.

@mwarning
Copy link
Collaborator

How about we add https://openwrt.github.io/firmware-selector-openwrt-org/ to the github project description? This has snapshots enabled. But normal users should not be exposed to snapshots.

@efahl
Copy link
Contributor Author

efahl commented Nov 29, 2024

Sure, that would be good enough for me. Add a bit of verbiage "advanced users blah blah snapshots can brick your device..."

@KA2107
Copy link

KA2107 commented Nov 30, 2024

however it does not show 24.10 since it not in the .versions.json file.

@aparcar I do not see 23.05-SNAPSHOT, 22.03-SNAPSHOT, 21.02-SNAPSHOT and 19.07-SNAPSHOT in https://downloads.openwrt.org/.versions.json . Yet those are listed in https://openwrt.github.io/firmware-selector-openwrt-org/ . Why is 24.10-SNAPSHOT not listed then ? It has been a month since 24.10 was branched.

@efahl
Copy link
Contributor Author

efahl commented Nov 30, 2024

Why is 24.10-SNAPSHOT not listed then

When the FS show_snapshots config setting is enabled, it scans the .versions.json input for major versions, and synthesizes a new xx.yy-SNAPSHOT from what's there. Since there's no 24.10 version in .versions.json yet, it can't know to create a snapshot for it.

https://github.com/openwrt/firmware-selector-openwrt-org/blob/master/www/index.js#L789

Once 24.10.0-rc1 is published, the 24.10-SNAPSHOT will magically appear.

@mwarning
Copy link
Collaborator

mwarning commented Dec 1, 2024

OK, then let's add the link to the firmware selector mit the snapshots somewhere (https://openwrt.github.io/firmware-selector-openwrt-org/) and close this ticket. It is important for the common user not to the tempted or confused to download release snapshots.

@efahl
Copy link
Contributor Author

efahl commented Dec 2, 2024

If that's the general feeling, then I'd say take main SNAPSHOT out of the public firmware selector, too, as it is generally far more dangerous than the release snapshots.

@mwarning
Copy link
Collaborator

mwarning commented Dec 2, 2024

@efahl true, SNAPSHOT is far more dangerous. But at least it is not that easy to be mistaken as something stable.
But I am not inclided to discuss things I cannot change. :-)

@efahl
Copy link
Contributor Author

efahl commented Jan 19, 2025

Resolved in #58 (comment)

@efahl efahl closed this as completed Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants