Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python regression around crypto-method-agility #303

Open
chrysn opened this issue Aug 16, 2024 · 1 comment
Open

Python regression around crypto-method-agility #303

chrysn opened this issue Aug 16, 2024 · 1 comment
Assignees

Comments

@chrysn
Copy link
Collaborator

chrysn commented Aug 16, 2024

The lakers-python package suffered some regressions (or unnoticed API changes) between 8e926b0 (good) and aa6eca5 (bad). Commits inbetween could not be tested. The changes were part of #284 AFAICT.

To reproduce, check out aiocoap (eg. 0.4.11), and run:

$ tox -e py312-allextras exec --skip-pkg-install -- pip uninstall -y lakers-python
    # (just in case you had it installed before)
$ tox -e py312-allextras exec --skip-pkg-install -- pip install 'git+https://github.com/openwsn-berkeley/lakers/@4e4aac33c00538d5904b11716e94a417cd514ed5#egg=lakers-python&subdirectory=lakers-python'
$ tox -e py312-allextras -- -k 'TestServerEdhocKidKid and test_whoami_is_client'

The name of the failing test indicated that things go bad when both parties present their keys by Key ID.

I'll continue from there to dig further into what is going wrong.

@chrysn chrysn self-assigned this Aug 16, 2024
@geonnave
Copy link
Collaborator

That's weird, I just tested the kid<->kid version and the unit tests pass (see #304).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants