Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp StableHLO simplification paterns. #2586

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

GleasonK
Copy link
Member

Starting to look into porting new simplification patterns from MHLO to StableHLO and wanted to clean things up in the process to make StableHLO simplification/folders an overall better place to innovate:

  • Leverage DRR when possible. This is usually possible when the pattern isn't super complicated or the op being built doesn't have a region.
  • Order simplification patterns by op alphabetically, order tests alphabetically, ensure a test per simplification pattern.
  • Add code comments for each pattern of the format // Pattern: ... which can be used in the future for generating documentation.
  • Move patterns which fold constants to folder pass.

@GleasonK GleasonK merged commit a3e6892 into openxla:main Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants