Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yurthub podenvupdater filter #2159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

techworldhello
Copy link

@techworldhello techworldhello commented Oct 7, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Adds a filter in Yurthub that sets the KUBERNETES_SERVICE_HOST environment variable to the Yurthub proxy IP. This enhancement would ensure node autonomy for edge nodes when they are operating offline.

Which issue(s) this PR fixes:

Fixes #2158

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


NONE

other Note

I noticed that documentation on new features are added to the changelog.md when a new version is created eg. https://github.com/openyurtio/openyurt/pull/1425/files. But if the maintainers prefer that this is added as a part of this PR please let me know,

@techworldhello techworldhello force-pushed the wangjessi/add-yurthub-pod-env-filter branch from 33cfe73 to e432fd7 Compare October 7, 2024 03:43
@techworldhello techworldhello force-pushed the wangjessi/add-yurthub-pod-env-filter branch from e432fd7 to 05a6544 Compare October 8, 2024 12:52
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.96%. Comparing base (3713163) to head (05a6544).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
pkg/yurthub/filter/podenvupdater/filter.go 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
+ Coverage   56.09%   58.96%   +2.87%     
==========================================
  Files         186      211      +25     
  Lines       18092    18998     +906     
==========================================
+ Hits        10149    11203    +1054     
+ Misses       6910     6712     -198     
- Partials     1033     1083      +50     
Flag Coverage Δ
unittests 58.96% <90.00%> (+2.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techworldhello techworldhello force-pushed the wangjessi/add-yurthub-pod-env-filter branch from 05a6544 to bd28c99 Compare October 8, 2024 23:52
Copy link

sonarcloud bot commented Oct 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set KUBERNETES_SERVICE_HOST to Yurthub Proxy Address in Yurthub Component
2 participants