fix crash on rebind #574
Merged
fix crash on rebind #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keep binding objects around until server close
dovholuknf
reviewed
Nov 15, 2023
| struct binding_s *b = model_map_it_value(it); | ||
| if (!b->bound && b->waiter == NULL) { | ||
| it = model_map_it_remove(it); | ||
| free(b); |
There was a problem hiding this comment.
don't need to free b->bound or b->waiter, right? i assume not but always better to ask i suppose :) (i see bound is a boolean now)
There was a problem hiding this comment.
waiters are owned by the channel
dovholuknf
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fixes services are not bound, and assertion fails when edge router flaps #570]