Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #2505 adds central configuration with events #2539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewpmartinez
Copy link
Member

@andrewpmartinez andrewpmartinez commented Nov 14, 2024

@andrewpmartinez andrewpmartinez requested review from a team as code owners November 14, 2024 14:39
@plorenz
Copy link
Member

plorenz commented Nov 18, 2024

My initial reaction is that having config settings by defined in a typed/static way is good for discoverability, but makes adding new values very complicated. I'm wondering if we want to either go with a loosely typed JSON-ey map type structure or at least restrict the structured config type to the presentation layer.

If we go with the map structure all the way through, we lose discoverability and will rely more on doc. We'd probably also want code which checked that incoming config values names were in a hard-coded list. But adding new values would not required updating the REST/Model/Command/DB layers.

If we went with structured at the presentation layer, we wouldn't lose any discoverability and would only need to update that layer and would avoid needing to make updates to the model/command/db layers.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants