Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow delete of orphans #105

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

tumido
Copy link
Member

@tumido tumido commented Sep 8, 2022

Part of: #103

For now at least allow orphan cleanup. Automated solution in a follow up PR.

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2022
Copy link
Member

@SamoKopecky SamoKopecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@tumido
Copy link
Member Author

tumido commented Sep 12, 2022

/approve

@sesheta
Copy link
Member

sesheta commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SamoKopecky, tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@sesheta sesheta merged commit 5e3d74a into operate-first:main Sep 12, 2022
SamoKopecky pushed a commit to SamoKopecky/service-catalog that referenced this pull request Sep 28, 2022
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
@tumido tumido deleted the allow-orphan-cleanup branch November 2, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants