🌱 (fix) Revert: Check cluster is running for non-standalone Make targets

[camilamacedo86]

Reverts #437

If we see the logs https://github.com/operator-framework/catalogd/actions/runs/11819448861/job/32929383546 (ci job of PR where the change was introduced), we can see that this check is wrong and is always failing:

PS.: I don't think there's a need for this check. Proof of that is that besides it does not work, nothing changed. Therefore, I do not see value in this one.
Instead, I would prefer the targets of this project to be as similar as possible to those of https://github.com/operator-framework/operator-controller so that life for us contributors is easier.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.23%. Comparing base (55689e8) to head (9fddb33).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #461   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files          15       15           
  Lines        1224     1224           
=======================================
  Hits          468      468           
  Misses        706      706           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelanford]

I removed from the queue. Just wanted to discuss this a bit more because:

• the tests were passing when the PR merged. Are they failing now?
• Brett put quite a bit of effort into this and has good motivations. We should discuss what changes should be made to remediate problems.

[joelanford]

@camilamacedo86 can you point to a where the e2e or upgrade-e2e tests failed as a result of #437?

[camilamacedo86]

Hi @joelanford

@camilamacedo86 can you point to a where the e2e or upgrade-e2e tests failed as a result of #437?

See the description: #461 (comment)
The check fails always; it is wrong since it was added
That does not mean that the tests fail.

[joelanford]

That job didn't fail.

[camilamacedo86]

HI @joelanford

That job didn't fail.

Not because. As far as I can see, the check is wrong and not helpful for anything.
Just bring the noise in the command line every time we run.

[camilamacedo86]

It is closed in favour: #465
I missed the rebase with the master
Then, I need to create a local branch to do so.