Skip to content

Commit

Permalink
(bugfix): fix a bug in the containers image source
Browse files Browse the repository at this point in the history
where we always pulled image references using the canonical reference.
Now we pull images using the reference provided to the source. Using only
the canonical reference resulted in not respecting some mirroring configurations
related to tags because we never used tag-based references.

Signed-off-by: everettraven <everettraven@gmail.com>
  • Loading branch information
everettraven committed Oct 18, 2024
1 parent 3083879 commit 3e6eb54
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion internal/rukpak/source/containers_image.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func (i *ContainersImageRegistry) Unpack(ctx context.Context, bundle *BundleSour
// copy.Image can concurrently pull all the layers.
//
//////////////////////////////////////////////////////
dockerRef, err := docker.NewReference(canonicalRef)
dockerRef, err := docker.NewReference(imgRef)
if err != nil {
return nil, fmt.Errorf("error creating source reference: %w", err)
}
Expand Down

0 comments on commit 3e6eb54

Please sign in to comment.