Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Installed status condition setting #1374

Open
everettraven opened this issue Oct 14, 2024 · 0 comments
Open

Improve Installed status condition setting #1374

everettraven opened this issue Oct 14, 2024 · 0 comments

Comments

@everettraven
Copy link
Contributor

In a recent sync call on slack, we identified that our current InstalledBundleGetter doesn't return sufficient information to give us a clear picture to determine the appropriate Installed condition state.

After #1296 is fixed, we can implement the following behavior for the Installed condition to adhere to the level-based approach that is expected of Kubernetes controllers:

  • If we get a nil value and no error from the InstalledBundleGetter - nothing installed (i.e Installed == False)
  • If we get an error from the InstalledBundleGetter - Installed condition is set to Unknown
  • If we get a non-nil value from the InstalledBundleGetter and an error happens in a step leading to successful upgrade, Installed condition set to True and Progressing condition contains the upgrade failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant